This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229481 - Patch for: "Select all"/"Select none" buttons missing in "Clone Repository"/"Fetch"/"Pull"/"Push" wizard
Summary: Patch for: "Select all"/"Select none" buttons missing in "Clone Repository"/"...
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: PATCH_AVAILABLE, USABILITY
Depends on:
Blocks:
 
Reported: 2013-05-07 21:27 UTC by markiewb
Modified: 2013-05-15 02:30 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Shows the dialog (57.77 KB, image/png)
2013-05-07 21:27 UTC, markiewb 		Details
Proposed patch (12.35 KB, patch)
2013-05-12 19:41 UTC, markiewb 		Details | Diff
Patch in action (55.81 KB, image/png)
2013-05-12 19:42 UTC, markiewb 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-05-07 21:27:22 UTC 
Created attachment 134204 [details]
Shows the dialog

ACTUAL: in the 2nd step of the "Clone Repository" wizard there are missing buttons to select all branches. Currently you have to set the check mark at every single branch separately. This is annoying, when there are many branches.

EXPECTED: in the 2nd step of the "Clone Repository" wizard there are buttons to select all/none branches. 


NetBeans IDE Dev (Build 201305052300)
Comment 1 markiewb 2013-05-12 19:41:41 UTC 
Created attachment 134337 [details]
Proposed patch

I like to propose a patch to solve this issue.

The patch introduces "Select All|None" buttons. These are visible in the "Clone Repository"/"Fetch"/"Pull"/"Push" wizards of Git. The buttons are in sync with the list model. For example the "select all" button is only available if there are some items unchecked.

@Ondrej: Please have a look and commit if appropriate.
Comment 2 markiewb 2013-05-12 19:42:32 UTC 
Created attachment 134338 [details]
Patch in action
Comment 3 Ondrej Vrabec 2013-05-13 09:50:18 UTC 
thanks for the patch, pushed as core-main #c4d0c298b597
Comment 4 Quality Engineering 2013-05-15 02:30:09 UTC 
Integrated into 'main-golden', will be available in build *201305142300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c4d0c298b597
User: Benno Markiewicz <markiewb@netbeans.org>
Log: Issue #229481 - "Select all"/"Select none" buttons missing in "Clone Repository"/"Fetch"/"Pull"/"Push" wizard