This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229350 - Patch for: Show notification icon in table of Notification Center
Summary: Patch for: Show notification icon in table of Notification Center
Status: NEW
Alias: None
Product: platform
Classification: Unclassified
Component: Notifications (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Jan Peska
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-05-04 16:25 UTC by markiewb
Modified: 2013-07-18 08:15 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Proposed patch (6.41 KB, patch)
2013-05-04 16:29 UTC, markiewb 		Details | Diff
Proposed patch - removed rebel.xml (5.75 KB, patch)
2013-05-04 16:30 UTC, markiewb 		Details | Diff
Patch in action (10.49 KB, image/png)
2013-05-04 16:30 UTC, markiewb 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-05-04 16:25:44 UTC 
ACTUAL: the new implementation of the notification center doesn't show the icon of the notification in the table

EXPECTED: the icon of the notification is shown in the table

USECASE: Some people like me are visually-orientated. Instead of reading the message text first, they look at the icon and may react properly (f.e. ignore the message, because it is from a 3rd-party plugin).
Comment 1 markiewb 2013-05-04 16:29:30 UTC 
Created attachment 134104 [details]
Proposed patch

I like to propose a patch to solve the issue. The patch adds a column for the icon.

@NB-Devs: Please review, discuss with me and commit, if appropriate.
Comment 2 markiewb 2013-05-04 16:30:22 UTC 
Created attachment 134105 [details]
Proposed patch - removed rebel.xml
Comment 3 markiewb 2013-05-04 16:30:53 UTC 
Created attachment 134106 [details]
Patch in action
Comment 4 Jan Peska 2013-05-07 12:09:42 UTC 
I see your point, my only concern is that the icon does not always fit in the table (it can have any size) - even in your screenshot you can see that few pixels are missing so we have to at least adjust the row height to standard 16x16 icons. 

I've already thought about using the notification icon in table but I was always imagining it as a part of the message column (icon on the left as usual). Do you have an usecase or any other argument why it should be in separate column? I can't think of any...
Comment 5 markiewb 2013-05-07 21:16:30 UTC 
(In reply to comment #4)
> I've already thought about using the notification icon in table but I was
> always imagining it as a part of the message column (icon on the left as
> usual). Do you have an usecase or any other argument why it should be in
> separate column? I can't think of any...

No, there's no argument from my side why it cannot be integrated in the message column. Change it as you want.
Comment 6 Jaroslav Havlin 2013-07-18 08:15:31 UTC 
(In reply to comment #4)
> Do you have an usecase or any other argument why it should be in
> separate column? I can't think of any...
If the icons are in a separate column, you could use column sorting to "group" notifications from the same provider together. Maybe it could be useful for some users, maybe not :-)