This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 226916 - Patch for: Inconsistent label format of search vs. search/replace - use choice-format of MessageFormat too
Summary: Patch for: Inconsistent label format of search vs. search/replace - use choic...
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P4 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: NETFIX, PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-03-01 22:35 UTC by markiewb
Modified: 2013-07-23 21:58 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Shows the mismatch and the possible solution (92.12 KB, image/png)
2013-03-01 22:35 UTC, markiewb 		Details
Proposed patch (2.20 KB, patch)
2013-03-01 22:41 UTC, markiewb 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-03-01 22:35:37 UTC 
Created attachment 132091 [details]
Shows the mismatch and the possible solution

The label format of search and search/replace is inconsistent. Please align the label format of s/r to the format of search. Use choice format and use bold format instead of quotes.

See screenshot.

ACTUAL: 
Found 8 match(es) of "xxx" in 4 file(s). To be replaced with "foo".
Found 1 match(es) of "xxx" in 1 file(s). To be replaced with "foo".

EXPECTED: 
Found 8 matches of xxx in 4 files. To be replaced with foo. 
Found 1 match of xxx in 1 file. To be replaced with foo.
Comment 1 markiewb 2013-03-01 22:41:14 UTC 
Created attachment 132093 [details]
Proposed patch

I like to propose a patch to solve this issue. The simple patch only introduces the choice format for some labels.

For example:
Found {0} matching file(s). will 
   be replaced by
Found {0} matching {0,choice,1#file|1<files}.

@NB-Devs: Please review, discuss and commit! Thank you
Comment 2 Jaroslav Havlin 2013-03-04 09:33:13 UTC 
>@NB-Devs: Please review, discuss and commit! Thank you
The patch is OK. There is not much to discuss, you are right,
the messages should be consistent.
Thank you very much for providing the patch!

Integrated as http://hg.netbeans.org/core-main/rev/886a0ae59c8b
Comment 3 Quality Engineering 2013-03-05 01:49:52 UTC 
Integrated into 'main-golden', will be available in build *201303042300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/886a0ae59c8b
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #226916: Inconsistent label format of search vs. search/replace - use choice-format of MessageFormat too
Comment 4 markiewb 2013-07-23 21:58:53 UTC 
Verified in 201307222300