This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Use new API introduced in the issue 223317 to improve http://hg.netbeans.org/web-main/rev/5f3180f5cf11 change.
Created attachment 129116 [details] patch
Created attachment 129117 [details] patch
CCing Martin as I'm changing EJB core module.
Created attachment 129119 [details] patch
Thanks David for CCing and doing code clean-up. In any case I raised new task #223573 to redesign EJBsupport to be able to prune J2eeProjectCapabilities class so I'll take a look on this code base once again during NB74 developing phase. Only one comment: [MF01] Logic of - EjbFacadeVisualPanel2 - SessionEJBWizardPanel - WebProject looks changed to me, it doesn't catch server requirements any more. Please keep the "serverSupportsEJB31" related code for now - In the future I'll replace it with something like EJBSupport#isEjb31CapableServer (at least in the EJB cases). Thanks again...
(In reply to comment #5) > #223573 to redesign EJBsupport ok > [MF01] Logic [...] doesn't catch server requirements any more I see. I overlooked that server profiles are checked *separately*. Which does not make sense, no? Calling for example J2eeProjectCapabilities.forProject(project).isEjb31Supported() should return true if all conditions for EJB 31 development in given project are satisfied and that includes also checking server associated with project. I'm attaching a patch which address this part of the problem. I have not tested any of the patches in this issue.
Created attachment 129176 [details] separate patch for J2eeProjectCapabilities
(In reply to comment #6) > > [MF01] Logic [...] doesn't catch server requirements any more > > I see. I overlooked that server profiles are checked *separately*. Which does > not make sense, no? Actually I think that it makes pretty well sense in the context where is J2eePC.isEjb31Supported() used. I.e. it distinguishes which file templates are recommended in the web/maven web projects. We *don't want* to base it on the chosen server instance. > Calling for example > > J2eeProjectCapabilities.forProject(project).isEjb31Supported() > > should return true if all conditions for EJB 31 development in given project > are satisfied and that includes also checking server associated with project. BTW, also we should keep in mind that Maven EE projects still be used w/out server instance, so it means that many wizards and recommended templates would stop working for them as well. > I'm attaching a patch which address this part of the problem. I have not tested > any of the patches in this issue. I'm pretty sure, that the EJBsupport will behave in the similar way you tried out to do in the J2eeProjectCapabilities, but the second patch doesn't look well to me at all, sorry. I propose to stay only with the first patch (fixed for the server capabilities). I'm going to rewrite all EJB usages of the J2eeProjectCapabilities and I don't want to bring any regression caused by quick fixes there.