This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 22173 - Name of TokenIterator misleading
Summary: Name of TokenIterator misleading
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Lexer (show other bugs)
Version: 3.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-07 20:52 UTC by Jaroslav Tulach
Modified: 2002-07-19 15:22 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Patch that shows how the misleading TokenIterator can be replaced by few methods in IncrementalAlgorithm (8.28 KB, patch)
2002-04-08 19:40 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2002-04-07 20:52:17 UTC
When I first saw the package javadoc of the lexer
package, I had
     problems to find out what classes are
designed for what. I knew that
     there are two things - the lexer and the
incremental algorithm. But the
     TokenConstants class was totaly unrelated to
anything - now there is a
     comment in Javadoc, but I am still not able
to realize the reason of
     putting this into separate class...

     The second problem I had was with
TokenIterator. It starts with word
     Token, so I immediatelly connected it with
Token, TokenCathegory and
     TokenId - but it is not true, it is connected
with the algorith. Please
     for the sanity of future readers of the API
do something with this. That
     is what I want to emphsize.

     I suggested you to make the TokenIterator
inner class of the algorithm
     or merge it with the algorithm to make the
clear cut between lexer and
     algorithm part.
Comment 1 Jaroslav Tulach 2002-04-08 19:40:37 UTC
Created attachment 5324 [details]
Patch that shows how the misleading TokenIterator can be replaced by few methods in IncrementalAlgorithm
Comment 2 Miloslav Metelka 2002-05-28 11:39:01 UTC
TokenConstants is removed from API. It's now just experimental class
for the swing support part of the lexer module.