This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220907 - Regression: JSP code completion does not auto complete page import anymore!
Summary: Regression: JSP code completion does not auto complete page import anymore!
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Martin Fousek
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2012-10-26 10:32 UTC by ecerichter
Modified: 2012-11-05 11:03 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Page import show case (25.15 KB, image/png)
2012-10-26 10:33 UTC, ecerichter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ecerichter 2012-10-26 10:32:27 UTC
Product Version = NetBeans IDE Dev (Build 201210210002)
Operating System = Windows 7 version 6.1 running on amd64
Java; VM; Vendor = 1.7.0_09
Runtime = Java HotSpot(TM) 64-Bit Server VM 23.5-b02

Writing a JSP page, when I type a Class Name in a expression, up to version 7.2 NetBeans completed the classname and added the page import directive for me.
This is not working anymore in 7.3 dev build.
See attached screenshot for reference.
In the cursor position ("|" after classname), if I hit "Ctrl+Space", page import should happen, but nothing happens.
Comment 1 ecerichter 2012-10-26 10:33:14 UTC
Created attachment 126610 [details]
Page import show case
Comment 2 Vladimir Riha 2012-10-28 21:45:42 UTC
reproducible 

Product Version: NetBeans IDE Dev (Build 201210250921)
Java: 1.7.0; Java HotSpot(TM) 64-Bit Server VM 21.0-b17
Runtime: Java(TM) SE Runtime Environment 1.7.0-b147
System: Linux version 3.5.0-17-generic running on amd64; UTF-8; en_US (nb)
Comment 3 Petr Jiricka 2012-10-30 09:27:57 UTC
Martin is looking into this - thanks.
Comment 4 Martin Fousek 2012-10-31 16:28:29 UTC
(In reply to comment #3)
> Martin is looking into this - thanks.

Right, what I found out so far was that it can't work with current java sources since the ImportProcessor isn't called any more - updateImports action looks to me to be processed differently but I'm not author of the previous solution so I'll have to debug it more in the NB7.2 sources to get to the cause of the regression.
Comment 5 Martin Fousek 2012-11-01 07:45:44 UTC
I'm afraid that this is regression since fix for:
http://netbeans.org/bugzilla/show_bug.cgi?id=218824

dbalek, should the JSP implement Import hooks differently? It looks to me that since changeset http://hg.netbeans.org/web-main/rev/1a1795bc066e (line 1176) is not called the ImportProcessor and resolveImport() for .jsps anymore. You will know for sure better whether there should happen change on java or jsp side. Thanks in advance for any advice.
Comment 6 Dusan Balek 2012-11-02 09:34:00 UTC
Fixed in jet-main.

http://hg.netbeans.org/jet-main/rev/b4c62031543d
Comment 7 Martin Fousek 2012-11-02 09:49:02 UTC
Thanks dbalek.
Comment 8 Quality Engineering 2012-11-03 02:41:41 UTC
Integrated into 'main-golden', will be available in build *201211030001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/b4c62031543d
User: Dusan Balek <dbalek@netbeans.org>
Log: Issue #220907: Regression: JSP code completion does not auto complete page import anymore - fixed.
Comment 9 Vladimir Riha 2012-11-05 08:08:32 UTC
verified, after completing class name, import is added


Product Version: NetBeans IDE Dev (Build web-main-9101-on-20121104)
Java: 1.7.0_10-ea; Java HotSpot(TM) Client VM 23.6-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_10-ea-b11
System: Linux version 3.2.0-32-generic-pae running on i386; UTF-8; en_US (nb)
Comment 10 ecerichter 2012-11-05 11:03:39 UTC
I can confirm it is working as expected in night build 201211020001.

Thanks for the fast fix!

Edson