This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220789 - Please rename "Copy Selection else Line down"
Summary: Please rename "Copy Selection else Line down"
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Actions/Menu/Toolbar (show other bugs)
Version: 7.2
Hardware: PC Windows 7
: P4 normal (vote)
Assignee: Miloslav Metelka
URL:
Keywords: USABILITY
Depends on: 207660
Blocks:
  Show dependency tree
 
Reported: 2012-10-24 23:41 UTC by kaamil1984
Modified: 2012-12-11 03:02 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kaamil1984 2012-10-24 23:41:47 UTC
Someone reported that feature request (its not a bug):

http://netbeans.org/bugzilla/show_bug.cgi?id=207660

but im unsatisfied how you fixed this.

Menu option has completely diffrent name than action.

It's really hard to find this:

    Copy Selection else Line down    
    Copy Selection else Line up

Please change this. I suggest something like this:

    Copy Selection else Duplicate Line down    
    Copy Selection else Duplicate Line up

so users can find that in window Tools-Options-Keymap, not in bug reports.

Regards
Kamil
Comment 1 Milutin Kristofic 2012-11-08 17:20:35 UTC
Petr, can you give your opinion.

In idea it is named *duplicate line or block* (ctrl+D). They have one action. We have two actions, which do almost same. Maybe we can merge both action. 

I don't like renaming. We cannot have all synonyms in action names.
Comment 2 Petr Somol 2012-12-10 15:34:45 UTC
When editing Java source, these actions are accessible from menu Source->Duplicate Up (Ctrl+Shift+UP) and Source->Duplicate Down (Ctrl+Shift+DOWN). This is a very simplified description of the actions but it makes sense and works well (users can easily discover how it works with and without selection).

The action names I see in Options->Keymap that represent the same are:
Copy Selection else Line Down, Ctrl+Shift+KP_DOWN
Copy Selection else Line Down (alternative shortcut), Ctrl+Shift+DOWN
Copy Selection else Line Up, Ctrl+Shift+KP_UP
Copy Selection else Line Up (alternative shortcut), Ctrl+Shift+UP

These names are completely confusing. The word "duplicate" is completely missing although it describes the essence of the actions the best, and the "else" makes me guess that this action does the following: "copy selection (=Ctrl-C), or, for some unclear reason, move cursor down by one line".
Actually the wording "Copy Selection" is misleading for one more reason - the action always affects whole line, but the name of the action can wrongly suggest that just parts of the lines that happen to be selected are actually copied.
So I fully support the idea to rename these actions to correct the apparently misleading names and to increase chances that they would be discovered if needed. The wording proposed in the Description of this issue, however, improves only a little and leaves the confusing "else". I would try to find a better wording. What would you say to:

Duplicate Line(s) Down, Ctrl+Shift+KP_DOWN
Duplicate Line(s) Down (alternative shortcut), Ctrl+Shift+DOWN
Duplicate Line(s) Up, Ctrl+Shift+KP_UP
Duplicate Line(s) Up (alternative shortcut), Ctrl+Shift+UP

IMHO this would be significantly more clear at first sight. And the little trick with (s) in "Line(s)" actually hints that it may relate to either one line (that would naturally be the line under the cursor), or multiple lines. But how can a shortcut affect multiple lines ? The immediate natural expectation would be that those lines under selection would be affected. But it still remains clear that whole lines will be duplicated and not just parts inside selection.

Thoughts or comments ?
Comment 3 Milutin Kristofic 2012-12-10 16:53:27 UTC
I renamed following:
  2.7 -move-selection-else-line-up=Move Selection else Line up
     2.8 -move-selection-else-line-down=Move Selection else Line down
     2.9 -copy-selection-else-line-up=Copy Selection else Line up
    2.10 -copy-selection-else-line-down=Copy Selection else Line down
    2.11 +move-selection-else-line-up=Move Line(s) Up
    2.12 +move-selection-else-line-down=Move Line(s) Down
    2.13 +copy-selection-else-line-up=Duplicate Line(s) Up
    2.14 +copy-selection-else-line-down=Duplicate Line(s) Down



http://hg.netbeans.org/jet-main/rev/204a865be859
Comment 4 Quality Engineering 2012-12-11 03:02:41 UTC
Integrated into 'main-golden', will be available in build *201212110001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/204a865be859
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #220789 - Please rename "Copy Selection else Line down"