This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 22058 - need unique help IDs for JP wizard panes 3-5
Summary: need unique help IDs for JP wizard panes 3-5
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: jarpackager (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P2 blocker (vote)
Assignee: Milos Kleint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-03 14:30 UTC by Patrick Keegan
Modified: 2003-07-01 10:00 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
snippets from log file, with notes of when the output appeared (15.89 KB, text/plain)
2002-04-04 14:26 UTC, Patrick Keegan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Keegan 2002-04-03 14:30:47 UTC
Panes 3 and 4 reuse the help ID from the JAR Content prop editor, which makes it very 
awkward to map this ID (org.netbeans.modules.jarpackager.DataObjectListEditor) to 
appropriate topic. Please provide new IDs for these wizard panes.

Also, pane 5 reuses org.netbeans.modules.jarpackager.ManifestTab, which the Manifest prop 
editor uses. Pane 5 should have a unique ID.
Comment 1 Patrick Keegan 2002-04-03 14:32:15 UTC
Marking as 3.3.2_CANDIDATE. Justification: Very easy fix + helps solve 
very ugly docs problem.
Comment 2 Milos Kleint 2002-04-03 14:39:15 UTC
ok.
Comment 3 Milos Kleint 2002-04-04 07:16:13 UTC
done. the 3rd and 5th panel should have a unique IDs. However the 4th
panel has already it's own id..
org.netbeans.modules.jarpackager.wizard.ContentMemberPanel

please reopen if that's not true, thanks.

Comment 4 Patrick Keegan 2002-04-04 09:26:19 UTC
will check org.netbeans.modules.jarpackager.wizard.ContentMemberPanel

Milos, could you give me the IDs for the other panels? Thanks.
Comment 5 Milos Kleint 2002-04-04 09:28:45 UTC
org.netbeans.modules.jarpackager.wizard.ManifestWizardPanel
and
org.netbeans.modules.jarpackager.wizard.ContentWizardPanel
Comment 6 Patrick Keegan 2002-04-04 14:26:09 UTC
Created attachment 5292 [details]
snippets from log file, with notes of when the output appeared
Comment 7 Patrick Keegan 2002-04-04 14:27:55 UTC
Not working for me. All of the old IDs are still being used.

Using the -J-Dorg.netbeans.core.Help=0 switch, I noticed that the 
setHelpIDString method is called on each panel *before* the user 
clicks Help and these IDs seem to override what gets assigned later. 
See the attachment for snippets of the log file, along with 
explanation of when the various output appears.

My guess is that the help ID needs to be set with the setHelpIDString 
method for each of these panels instead of the way you did it.



Comment 8 Milos Kleint 2002-04-04 14:45:16 UTC
just to be sure.. I've fixed it this morning, you're using continuous
build or built it yourself?
Comment 9 Patrick Keegan 2002-04-04 15:01:26 UTC
I checked it in a continuous build from this afternoon (using a hacked 
version of usersguide). Since then I've checked new pages into 
usersguide for each wizard pane, so it should be obvious when it 
starts working.
Comment 10 Patrick Keegan 2002-04-11 16:31:31 UTC
I just noticed that the change has been made only in the trunk. 
However, the change in the trunk only works correctly for panel 4. 
Clicking help on panel 3 and panel 5 still displays the wrong help. 
Milos, can you please look at this again. This is important for Orion.
Comment 11 Milos Kleint 2002-04-24 09:14:09 UTC
ok, will look at this today/tommorow.. sorry for the delay I was ill..
Comment 12 Milos Kleint 2002-04-24 13:38:05 UTC
i've commited a more brute force fix (compared to the first one) that
should ensure the correct helpids.. Patrick, please let me know if
it's ok, so that we can push it into orion ASAP.

panel 3 - ContentWizardPanel.class
panel 5 - ManifestWizardPanel.class
Comment 13 Patrick Keegan 2002-04-24 15:15:43 UTC
verified in trunk
Comment 14 Patrick Keegan 2002-04-24 16:34:33 UTC
Upgrading to P2. The help is particularly necessary to get right on 
these wizard panes since the behavior of the wizard fields is not 
completely intuitive or consistent with the type of behavior used in 
other parts of the IDE.
Comment 15 Milos Kleint 2002-04-25 08:13:23 UTC
merged into the orion_fcs branch.
Comment 16 Quality Engineering 2003-07-01 09:59:00 UTC
Resolved for 3.4 or earlier, no new info since then -> closing.
Comment 17 Quality Engineering 2003-07-01 10:00:06 UTC
Resolved for 3.4 or earlier, no new info since then -> closing.