Adding @PropertyEditorRegistration and @PropertyEditorSearchPath annotations to allow convenient registration of property editors. Setting the property editor search path in multiple places is error prone in multithreaded environment. @PropertyEditorSearchPath annotation will facilitate the setting search path in one synchronized method.
Created attachment 124317 [details]
It is probably better to attach diff in plain format rather than gzipped.
Thanks for fixing the usages in all the modules! I am sure module owners will be glad when they see your commit.
Y01 You don't want to integrate
Y02 Javadoc of registerPropertyEditors is unfinished and is missing @since tag.
Y03 Javadoc of PropertyEditorRegistration could refer to NodeOp#registerPropertyEditors. Same for PropertyEditorSearchPath
Y04 Remove runtime dependency of Nodes on filesystems, enough to have just:
Y05 Missing @since tag on the new annotation classes.
Y06 I've noticed setBeanInfoSearchPath in xml.tax module. Do you plan to add @BeanInfoSearchPath?
To Y01: use nbbuild/user.build.properties for local overrides.
To Y06: cf. bug #210323.
Y06 I plan to implement @BeanInfoSearchPath next month
Created attachment 124658 [details]
I apologize, but I had to revert:
which is bringing this into jet-main. Not only it breaks ValidateLayerConsistencyTest.testInstantiateAllInstances:
Some instances cannot be created
File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-BoolEditor.instance should declare instanceOf
File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-CharEditor.instance should declare instanceOf
File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-IntEditor.instance should declare instanceOf
File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-StringArrayEditor.instance should declare instanceOf
File Services/PropertyEditorManager/Package-org-netbeans-beaninfo-editors.instance should declare instanceOf
File Services/PropertyEditorManager/Package-org-netbeans-core-execution-beaninfo-editors.instance should declare instanceOf
File Services/PropertyEditorManager/Package-org-netbeans-modules-xml-tax-beans-editor.instance should declare instanceOf
File Services/PropertyEditorManager/Package-org-openide-explorer-propertysheet-editors.instance should declare instanceOf Log:
but it also breaks the org.netbeans.beaninfo.editors.FindEditorTest. I could probably hotfix the VLCT, but not sure how to fix FET (I guess the test now requires generated-layer.xml to be available?).
I apologize for inconvenience, but we need to ensure propagation of changes from jet-main. Please fix the tests and commit again (consider also using core-main, which may be more appropriate for this change).
Integrated into 'main-golden', will be available in build *201209230001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
User: Jan Horvath <email@example.com>
Log: #218300 - Adding @PropertyEditorRegistration and @PropertyEditorSearchPath annotations
fixed in http://hg.netbeans.org/core-main/rev/b1efa878877e
Thanks for the contribution and don't forget your @BeanInfoSearchPath promise...