This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 217873 - Startup deadlock on Keyring
Summary: Startup deadlock on Keyring
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3
Hardware: PC All
: P1 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 09:38 UTC by Petr Hejl
Modified: 2013-01-11 11:43 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
threaddump (25.47 KB, text/plain)
2012-09-05 09:40 UTC, Petr Hejl
Details
Thread dump from 201209170001. (37.12 KB, text/plain)
2012-09-17 08:18 UTC, Jiri Skrivanek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2012-09-05 09:38:19 UTC
This change introduced startup deadlock: 4d242554289f. Never call Keyring from code called on nb start. It may cause a deadlock when fallback keyring is used and it is not very user friendly showing the keyring dialog without any user action (user did nothing and ide is asking for password). Ask for password when it is really needed.
Comment 1 Petr Hejl 2012-09-05 09:40:14 UTC
Created attachment 123934 [details]
threaddump
Comment 2 TomasKraus 2012-09-06 15:36:33 UTC
I changed administrator user password init (Keyring read) to be lazy.
It's read with first get request.

changeset:   232208:d9a3176366c1
summary:     Bug# 217873 - Removal of deadlock on Keyring using lazy
             password init

Pushed to web-main.
Comment 3 Jiri Skrivanek 2012-09-17 08:18:32 UTC
Created attachment 124431 [details]
Thread dump from 201209170001.
Comment 4 Jiri Skrivanek 2012-09-17 08:19:55 UTC
Not fixed.

Product Version: NetBeans IDE Dev (Build 201209170001)
Java: 1.7.0_07; Java HotSpot(TM) 64-Bit Server VM 23.3-b01
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)
Comment 5 TomasKraus 2012-09-17 11:49:54 UTC
It was fixed, this is another one.

AWT-EventQueue-1: 0x00000000d03f0408, 0x00000000d03f05a8
TimerQueue: 0x00000000d03f05a8, 0x00000000d03f0408
pool-1-thread-1: 0x00000000f5be8cd8, 0x00000000d03f0408

Lock request cycle is in AWT-EventQueue-1 and TimerQueue where no GF module code is involved.

pool-1-thread-1 is just waiting for 0x00000000d03f0408 lock forever.
Comment 6 TomasKraus 2012-09-17 13:04:11 UTC
Last issue you saw is a duplicate of bug# 213926. I'm closing this bug again.

But I won't mark this as a duplicate because of previous deadlock fix which is unique.