This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 217619 - Glassfish EE Common, Utils should use getDisplayName() method instead of getName()
Summary: Glassfish EE Common, Utils should use getDisplayName() method instead of getN...
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3
Hardware: PC All
: P3 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks: 213873 215274
  Show dependency tree
 
Reported: 2012-08-30 11:49 UTC by Martin Janicek
Modified: 2012-11-08 02:53 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Janicek 2012-08-30 11:49:17 UTC
See issue 215976#16 for some background and see Glassfish EE Common module, class org.netbeans.modules.glassfish.eecommon.api.Utils, method computeModuleID(), line 132

There is a getName() method call on the ProjectInformation instance which isn't a good solution and we should rather use getDisplayName() method.
I would change the method call, but can't say if it's completely safe to do that (there is a lot of things which seems to have dependency to computeModuleID return value - e.g. the Maven project with Glassfish server deployment etc.)
Comment 1 Martin Janicek 2012-10-31 15:14:03 UTC
Tomas would it be possible to fix this for 7.3? It's blocking two Java EE maven issues (they are not a P2, but can imagine both might be problematic for users).
I know there are some P1-P2s in Glassfish area at the moment, but if you find some free time, please take a look at this one.. thanks in advance.
Comment 2 TomasKraus 2012-11-07 14:43:21 UTC
OK, switching to getDisplayName().
I checked ant-based web projects and they also seem to use display name.
Comment 3 TomasKraus 2012-11-07 14:45:57 UTC
NetBeans web-main:
------------------
changeset:   238430:781969bd0560
summary:     #217619 - Method computeModuleID() uses
             [ProjectInformation].getDisplayName() to compute ID now
Comment 4 TomasKraus 2012-11-07 14:49:02 UTC
Jiri, please check that mvn project s life cycle (build/deploy/redeploy) is still working fine. I tested WEB application and it's ok.
It changed deployed application name to project's display name which is the correct one.
Comment 5 Quality Engineering 2012-11-08 02:53:44 UTC
Integrated into 'main-golden', will be available in build *201211080001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/781969bd0560
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #217619 - Method computeModuleID() uses [ProjectInformation].getDisplayName() to compute ID now