Bug 217091 - Navigator "Toolbar" panel
Navigator "Toolbar" panel
Status: RESOLVED FIXED
Product: platform
Classification: Unclassified
Component: Navigator
7.2
PC All
: P3 (vote)
: 7.3
Assigned To: apireviews
issues@platform
: API_REVIEW_FAST
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-20 09:48 UTC by Jan Peska
Modified: 2012-08-23 08:08 UTC (History)
0 users

See Also:
Issue Type: DEFECT
:


Attachments
Netbeans UI after the change (272.36 KB, image/png)
2012-08-20 09:48 UTC, Jan Peska
Details
Proposed changes (13.51 KB, patch)
2012-08-20 11:58 UTC, Jan Peska
Details | Diff
Proposed changes #2 (18.65 KB, patch)
2012-08-20 12:48 UTC, Jan Peska
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Peska 2012-08-20 09:48:47 UTC
Created attachment 123302 [details]
Netbeans UI after the change

Add a new SPI interface. Clients will implement this interface when they need a toolbar for their Navigator view/panel. Toolbar will be displayed on the top of the Navigator window, next to the panel chooser (ComboBox) - see attached screenshot.
Comment 1 Jan Peska 2012-08-20 11:35:12 UTC
See http://wiki.netbeans.org/UEXInspectMembersAndHierarchies#Proposal_for_NetBeans_7.3 for more info about the reason behind it.
Comment 2 Jan Peska 2012-08-20 11:58:57 UTC
Created attachment 123305 [details]
Proposed changes
Comment 3 Jan Peska 2012-08-20 11:59:28 UTC
Please review attached patch.
Comment 4 Jaroslav Tulach 2012-08-20 12:04:46 UTC
Y01 Don't prefix the name of interface with '@', that resembles annotation type, imho.

Y02 Why NavigatorPanelWithToolbar extends NavigatorPanelWithUndo. Should not it extend only NavigatorPanel?

Y03 There is no test. Write at least one, please.
Comment 5 Jan Peska 2012-08-20 12:48:24 UTC
Created attachment 123308 [details]
Proposed changes #2
Comment 6 Jan Peska 2012-08-20 12:48:56 UTC
Y01 - done

Y02 - Yes it should. Corrected.

Y03 - done. I've added a new test, similar to the UndoRedo feature test.
Comment 7 Tomas Zezula 2012-08-23 05:53:54 UTC
The proposed patch seems good to me.
Please integrate it.
Comment 8 Jaroslav Tulach 2012-08-23 07:25:22 UTC
OK. Just two little comments. Use {@link ClassName} to refer to classes in Javadoc - e.g. in sentence "top of basic NavigatorPanel and NavigatorPanelWithUndo features.". Second, there is left System.out.println in the test which is probably not essential for the test execution and only pollutes the output with unnecessary garbage. If the output is essential for diagnosing failures consider using Logger and override "logLevel" method of NbTestCase.
Comment 9 Jan Peska 2012-08-23 08:08:52 UTC
main fix: http://hg.netbeans.org/core-main/rev/8ed357830687

fix two little comments (main fix was already pushed when I realize there is another comment): http://hg.netbeans.org/core-main/rev/066222208653


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo