This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 123302 [details] Netbeans UI after the change Add a new SPI interface. Clients will implement this interface when they need a toolbar for their Navigator view/panel. Toolbar will be displayed on the top of the Navigator window, next to the panel chooser (ComboBox) - see attached screenshot.
See http://wiki.netbeans.org/UEXInspectMembersAndHierarchies#Proposal_for_NetBeans_7.3 for more info about the reason behind it.
Created attachment 123305 [details] Proposed changes
Please review attached patch.
Y01 Don't prefix the name of interface with '@', that resembles annotation type, imho. Y02 Why NavigatorPanelWithToolbar extends NavigatorPanelWithUndo. Should not it extend only NavigatorPanel? Y03 There is no test. Write at least one, please.
Created attachment 123308 [details] Proposed changes #2
Y01 - done Y02 - Yes it should. Corrected. Y03 - done. I've added a new test, similar to the UndoRedo feature test.
The proposed patch seems good to me. Please integrate it.
OK. Just two little comments. Use {@link ClassName} to refer to classes in Javadoc - e.g. in sentence "top of basic NavigatorPanel and NavigatorPanelWithUndo features.". Second, there is left System.out.println in the test which is probably not essential for the test execution and only pollutes the output with unnecessary garbage. If the output is essential for diagnosing failures consider using Logger and override "logLevel" method of NbTestCase.
main fix: http://hg.netbeans.org/core-main/rev/8ed357830687 fix two little comments (main fix was already pushed when I realize there is another comment): http://hg.netbeans.org/core-main/rev/066222208653