This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Development build #200203150100 of NetBeans 3.4 on Windows 2000 with JDK 1.4 b92 Description: ============ I think that some actions like "VSS|Set Password" or "CVS|Login" and "CVS|Logout" should be disabled in popup menu of VCS groups because when invoked they display the same dialogs for each file in group which I consider rather as a design flaw and users may get upset. I propose to enable those actions only on root of their filesystem. Steps to reproduce: =================== 1. Mount CVS filesystem using Command-line Client. 2. Right click two files in explorer and choose "Include in VCS Group|<Default Group>" popup menu item. 3. Invoke "Versioning|VCS Groups" menu item from main window. 4. Right click "<Default Group>" node and select "CVS|Login" menu action. 5. This will generate two login dialogs.
Reassigning...
I will set a property, that they can act on more files. This should prevent from running one command per each selected file. Having these commands only on the root of the FS will lead to the fact, that nearly nobody will ever find them.
Fixed in dev build Apr 17.
Asking UI guys for their evaluation. Is it all right that there is "CVS|Login" action in popup menu of folders or files although it is not context dependent ? The same goes for "VSS|Set Password". I suggest to show these actions only on root of filesystem.
Martin argued that it would not be visible and nobody would find that action. But we already have such an action: "CVS|Init". What's your opinion Filip ?
I agree with Jirka Kovalsky. The Login and Logout actions are not file/folder dependent and they apply to the whole filesystem, so the user should be able to invoke them only from the filesystem node, otherwise it can bring a confusion "Do I log in only for this file and will I not be logged in for other files?". And, as mentioned, we have the Init action which is the global one too and it is accessible only from filesystem node too. We should follow the same pattern in Login/Logout actions as well.
Well, there is a big difference between Init and Login/Logout actions. Init is used just once at the very beginning when there are usually no files in the filesystem and thus you have just the FS node anyway. Login/Logout can be used multiple times while you're working with the CVS FS. The user might never popup a menu on the FS root and thus never see this command. Even if the user knows that there is such command, it's hard to find it. But I agree, that from the conceptual point of view it's not nice to have a context-independent action on every file. It was meant as a usability enhancement for users to be able to find and use the provided functionality. Filip, if you're still convinced, that the Login/Logout actions should be ONLY on the FS root, please tell me and I'll do it. Thanks.
Well, after a discussion we have realized that there is an easier solution. If we add a server name to Login and Logout actions, it will be perfectly clear that the action does not apply to a single file but it performs a global login to/logout from the specified server. Another problematic action is Customize which can be invoked on files too but it customizes the whole filesystem, not the selected file. Here is an example: CVS | ... [CVS actions] | +-- Customize the filesystem | +-- Login to cvs.netbeans.org | +-- Logout from cvs.netbeans.org
Starting to work on it...
The Login/Logout problem fixed. Added UI keyword, since this is a change in UI. In order to fix this, it's possible now to insert variable values into the commands display names (e.g. "Login to ${CVS_SERVER}..."). Since this would look awfull when local connection method is used and CVS_SERVER variable is not defined, one new command "expert" property was introduced: "hiddenTestExpression" This is an expression which if evaluated as a non empty string, the corresponding command is not shown in the popup menu. Both Login and Logout commands define "hiddenTestExpression" property to be visible just when the chosen connection method is "pserver" and the CVS_SERVER is non empty.
"Customize Filesystem" is now instead of "Customize" in the Versioning menu. VSS -> "Set Password" renamed to "Set Password For ${WORKPROJ}" ( name of the project ---^^^ ) The issue is fixed in dev build Apr 29.
Okay. Verified in development build #200205020100 of NetBeans 3.4.
Resolved for 3.4.x or earlier, no new info since then -> closing.