This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 215098 - 44s - org.netbeans.modules.glassfish.common.nodes.Hk2ResourcesChildren.addNotify()
Summary: 44s - org.netbeans.modules.glassfish.common.nodes.Hk2ResourcesChildren.addNot...
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.1
Hardware: All All
: P3 normal (vote)
Assignee: TomasKraus
URL:
Keywords: PERFORMANCE
: 215813 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-02 22:59 UTC by Exceptions Reporter
Modified: 2013-07-18 02:39 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 190357


Attachments
nps snapshot (74.88 KB, application/nps)
2012-07-02 22:59 UTC, Exceptions Reporter
Details
nps snapshot (172.32 KB, application/nps)
2012-11-15 19:34 UTC, sreder
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Exceptions Reporter 2012-07-02 22:59:41 UTC
This bug was originally marked as duplicate of bug 184854, that is already resolved. This bug is still valid, so this seems to be another bug, but it might be related.

Build: NetBeans IDE 7.1.2 (Build 201204101705)
VM: Java HotSpot(TM) Client VM, 20.1-b02, Java(TM) SE Runtime Environment, 1.6.0_26-b03
OS: Windows 7
Maximum slowness yet reported was 44441 ms, average is 44441
Comment 1 Exceptions Reporter 2012-07-02 22:59:47 UTC
Created attachment 121673 [details]
nps snapshot
Comment 2 Jaroslav Tulach 2012-08-24 13:31:39 UTC
This is a duplicate of another bug I've reassigned, I guess. The addNotify should be fast.
Comment 3 TomasKraus 2012-08-30 15:54:25 UTC
This seems to be caused by CommandRunner#getResources called from Hk2ResourcesChildren#addNotify (thanks Jaroslav for explaining that snapshot staff to me).
Comment 4 TomasKraus 2012-09-07 13:43:28 UTC
*** Bug 215813 has been marked as a duplicate of this bug. ***
Comment 5 TomasKraus 2012-10-29 16:47:52 UTC
Targeting for next release. This would require nodes under server instance to be rewritten and I consider this change to be quite dangerous at this stage of 7.3 release cycle.
Comment 6 Marian Mirilovic 2012-11-02 11:22:54 UTC
(In reply to comment #5)
> Targeting for next release. This would require nodes under server instance to
> be rewritten and I consider this change to be quite dangerous at this stage of
> 7.3 release cycle.

Ok, so ask for waiver : http://wiki.netbeans.org/WaiverProcess

NO73 keyword is supposed be used for bugs not available in NB 7.3
Comment 7 TomasKraus 2012-11-02 11:38:24 UTC
I can simply make this P3. This was reported 4 times since 7.1.1 and it's not blocking any important functionality.
Comment 8 Marian Mirilovic 2012-11-02 11:41:02 UTC
(In reply to comment #7)
> I can simply make this P3. This was reported 4 times since 7.1.1 and it's not
> blocking any important functionality.

Marked as P2 by Yarda ... is there any particular reason you do not want to ask for a waiver ?
Comment 9 TomasKraus 2012-11-02 11:54:10 UTC
No, there is not. I'm just working with the fact that this issue is there for a long time and users are not complaining that much.

For P2 I would expect something affecting core functionality and causing significant usability problem of some important part of the plugin.

This one is just annoying from time to time, but it's not causing significant problems. that's why I don't think it's P2.
Comment 10 Petr Jiricka 2012-11-02 13:25:38 UTC
Cc'ing Jarda so he can provide justification for P2 priority; based on the number of reports I would also say this is P3. I agree NO73 keyword is not appropriate.
Comment 11 TomasKraus 2012-11-12 15:56:26 UTC
Jarda seems to be too busy now. Changing to P3 and keep targeted to next release. I already have some plans to rewrite this part of plugin after 7.3 will be frozen.
Comment 12 sreder 2012-11-15 19:34:31 UTC
Created attachment 127894 [details]
nps snapshot

Waiting on glassfish to refresh
Comment 13 TomasKraus 2013-07-16 13:56:59 UTC
Checked into web-main:
----------------------
changeset:   257843:e5db4ffb4087
tag:         tip
user:        Tomas Kraus <TomasKraus@netbeans.org>
date:        Tue Jul 16 15:47:25 2013 +0200
New server status monitoring framework integrated into GlassFish plugin.
Fixed bugs:
#231403 - Server process is not being killed. Server status is checked at   
          the background continuously.
#215098 - Slowness reports related to server status updates in AWT event
          queue are past now
#229020 - Start task was completely rewritten and there shall not be any 
          remote server query in AWT event queue now

This slowness should be fixed too. I'm not 100% sure if server status check was the only problem here - there seems to be another query. But I'll close it now.

It can be reopened with another 7.4 slowness report for builds after 17th July 2013 to let me know I have to search for another remote queries.
Comment 14 Quality Engineering 2013-07-18 02:39:57 UTC
Integrated into 'main-silver', will be available in build *201307172300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e5db4ffb4087
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: New server status monitoring framework integrated into GlassFish plugin.
Fixed bugs:
#231403 - Server process is not being killed. Server status is checked at
          the background continuously.
#215098 - Slowness reports related to server status updates in AWT event
          queue are past now
#229020 - Start task was completely rewritten and there shall not be any
          remote server query in AWT event queue now