This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 214951 - Hidden Text Box during REST endpoint creation
Summary: Hidden Text Box during REST endpoint creation
Status: VERIFIED FIXED
Alias: None
Product: webservices
Classification: Unclassified
Component: REST (show other bugs)
Version: 7.2
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Denis Anisimov
URL:
Keywords:
: 213142 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-28 22:27 UTC by arungupta
Modified: 2012-10-11 11:20 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
hidden text box (61.54 KB, image/png)
2012-06-28 22:27 UTC, arungupta
Details
New screenshot on Mac OS X 10.7.4 (59.59 KB, image/png)
2012-08-08 09:25 UTC, Petr Jiricka
Details
Screen shots of REST wizards. (226.99 KB, application/octet-stream)
2012-08-10 08:30 UTC, Jiri Skrivanek
Details
Screen shots - from patterns - Linux. (156.90 KB, application/octet-stream)
2012-09-06 17:59 UTC, Jiri Skrivanek
Details
Screen shots - from patterns - Linux - 20120917. (154.88 KB, application/octet-stream)
2012-09-17 09:17 UTC, Jiri Skrivanek
Details
Screen shots - from patterns - Linux - 20120920. (110.03 KB, application/octet-stream)
2012-09-20 07:44 UTC, Jiri Skrivanek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description arungupta 2012-06-28 22:27:51 UTC
Created attachment 121525 [details]
hidden text box

Create a new Web project
- Create a RESTful entity from design pattern

The wizard looks like as shown in the first attached image. What is the hidden text box under "Class Name:" for ? 

Even increasing the window size does not show all the text boxes as shown in the second attached image. 

The generated GenericResource has "import javax.ws.rs.PathParam;" and there is no @PathParam in the code. This is a redundant import.
Comment 1 Jiri Skrivanek 2012-07-30 13:00:02 UTC
Check layout of panel also on Linux (bug 213142).
Comment 2 Denis Anisimov 2012-08-07 08:11:13 UTC
*** Bug 213142 has been marked as a duplicate of this bug. ***
Comment 3 Denis Anisimov 2012-08-07 08:15:24 UTC
web-main#9708aa12c02a
Comment 4 Denis Anisimov 2012-08-07 08:16:46 UTC
Please verify it on the non-win platforms. I have only Win box.
Comment 5 Quality Engineering 2012-08-08 02:35:05 UTC
Integrated into 'main-golden', will be available in build *201208080001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/9708aa12c02a
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#214951- Hidden Text Box during REST endpoint creation
Comment 6 Petr Jiricka 2012-08-08 09:25:04 UTC
Created attachment 122853 [details]
New screenshot on Mac OS X 10.7.4

I must say it still does not work completely. The good news is that after the fix, resizing now shows the hidden fields, but by default it is still hidden, see the attached screenshot. Maybe there is just too much information in this wizard step?
Comment 7 Petr Jiricka 2012-08-08 09:26:55 UTC
This was using:
Product Version: NetBeans IDE Dev (Build web-main-8178-on-20120807)
Java: 1.7.0_06-ea; Java HotSpot(TM) 64-Bit Server VM 23.2-b09
System: Mac OS X version 10.7.4 running on x86_64; UTF-8; en_US (nb)
Comment 8 Denis Anisimov 2012-08-08 09:35:49 UTC
(In reply to comment #6)
> Created attachment 122853 [details]
> New screenshot on Mac OS X 10.7.4
> 
> I must say it still does not work completely. The good news is that after the
> fix, resizing now shows the hidden fields, but by default it is still hidden,
> see the attached screenshot. Maybe there is just too much information in this
> wizard step?

No, it is an issue with free design layout.
It works fine on Windows.
Comment 9 Denis Anisimov 2012-08-09 16:26:17 UTC
I'm trying to find the reason of the behavior.
I suppose the problem is absence of resize main wizard panel where custom 
components located: it is preferred size is not enough to show both panels and
first one is not shown in his preferred size.
But similar situation is true for RESTful from DB where first panel has bigger 
size than RESTful from Pattern even on Win platform.
And latter main wizard panel is resized correctly for me. All first panel 
is visible on Win.
Could you please check RESTful from DB on Mac OS/Linux ?
How it behaves respectively resizing.
If it also is not fully visible then REST config has to be moved out as a
separate step.
Comment 10 Jiri Skrivanek 2012-08-10 08:30:35 UTC
Created attachment 122975 [details]
Screen shots of REST wizards.

Attached are screen shots from Linux, NetBeans IDE Dev (Build 201208100001), JDK7u4.

- fromDB-02 is resized horizontally against fromDB-01
- BTW REST Application... fields are not aligned left and right
Comment 11 Petr Jiricka 2012-08-10 08:53:05 UTC
BTW, I also noticed that in fromDB-03.png, the wizard step title is missing (and I can reproduce it on Mac OS X as well).
Comment 12 Petr Jiricka 2012-08-30 20:19:44 UTC
So should at least the partial fix be transplanted to release72? Jiri Skrivanek is on vacation, cc'ing Tomas Danek.
Denis, can you please try to further improve the UI?
Comment 13 Tomas Danek 2012-08-31 06:00:59 UTC
Just to summarize: wizard generates compilable code even before fix in comment #3, right? 
Petre, is this a regression from 7.1(.X)? if yes, partial fix could be transplanted, otherwise I'm for to leave it for patch2.
Comment 14 Denis Anisimov 2012-08-31 07:41:31 UTC
(In reply to comment #13)
> Just to summarize: wizard generates compilable code even before fix in comment
> #3, right? 
> Petre, is this a regression from 7.1(.X)? if yes, partial fix could be
> transplanted, otherwise I'm for to leave it for patch2.

I wouldn't say that this is a regression. It is a consequence of UI change.
7.1 UI differs from current UI and the latter has the issue.
Hidden fields has a default values so it doesn't affect the generated code.
Comment 15 Denis Anisimov 2012-08-31 07:57:22 UTC
(In reply to comment #10)
> Created attachment 122975 [details]
> Screen shots of REST wizards.
> 
> Attached are screen shots from Linux, NetBeans IDE Dev (Build 201208100001),
> JDK7u4.
> 
> - fromDB-02 is resized horizontally against fromDB-01
> - BTW REST Application... fields are not aligned left and right

Sorry I've mistaken.
I meant the similar REST from Pattern wizards: "Container-Item" and especially 
"Client-Controlled Container-Item". The last one is resized on the height on Win as well and it looks correctly rendered.
Could you please check the wizards on Linux/Mac OS  as well ?

Thanks.
Comment 16 Jiri Skrivanek 2012-09-05 12:05:25 UTC
Screenshots from Linux are attached (see comment 10). From that time there is no changeset mentioned, so I expect it is not fixed yet. I am changing target to patch2.
Comment 17 Denis Anisimov 2012-09-05 12:33:25 UTC
You've attached screenshots for RESTful from DB and RESTful from Patterns for Simple Root Resource.
Could you please attach screenshots for RESTful from Patterns for Container-Item 
and Client-Controlled Container-Item ?
Those two wizards has panels which are correctly resized even on Win.
Comment 18 Jiri Skrivanek 2012-09-06 17:59:08 UTC
Created attachment 123996 [details]
Screen shots - from patterns - Linux.
Comment 19 Denis Anisimov 2012-09-07 07:04:45 UTC
(In reply to comment #18)
> Created attachment 123996 [details]
> Screen shots - from patterns - Linux.

Thank you.
So these wizards have similar issues.
Comment 20 Denis Anisimov 2012-09-13 11:04:42 UTC
Please verify the fix attempt on Linux and Mac
web-main#983edffbfb1c
Comment 21 Quality Engineering 2012-09-14 02:08:50 UTC
Integrated into 'main-golden', will be available in build *201209140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/983edffbfb1c
User: Denis Anisimov <ads@netbeans.org>
Log: Attepmt to fix for BZ#214951 - Hidden Text Box during REST endpoint creation
Comment 22 Jiri Skrivanek 2012-09-17 09:16:23 UTC
Still the same on Linux with build 201209170001, JDK7u4.
Comment 23 Jiri Skrivanek 2012-09-17 09:17:02 UTC
Created attachment 124435 [details]
Screen shots - from patterns - Linux - 20120917.
Comment 24 Denis Anisimov 2012-09-17 10:08:31 UTC
Thank you for verification and images.
Comment 25 Denis Anisimov 2012-09-17 12:06:22 UTC
web-main#d2fdff2e3976
Comment 26 Quality Engineering 2012-09-18 02:09:56 UTC
Integrated into 'main-golden', will be available in build *201209180001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/d2fdff2e3976
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#214951 - Hidden Text Box during REST endpoint creation
Comment 27 Jiri Skrivanek 2012-09-18 09:25:10 UTC
It is still the same with build 201209180001. Previous screen shots are still valid. I also wonder that Container Item and Client Controlled Container Item have the same panel now.
Comment 28 Denis Anisimov 2012-09-19 12:40:34 UTC
web-main#d25b7ff356d4
Comment 29 Quality Engineering 2012-09-20 02:26:43 UTC
Integrated into 'main-golden', will be available in build *201209200001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/d25b7ff356d4
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#214951 - Hidden Text Box during REST endpoint creation
Comment 30 Jiri Skrivanek 2012-09-20 07:43:40 UTC
Great! Now all fields are visible. But sorry for nitpicking there are still some minor issues which definitely are easy to fix (see screen shots):
- Simple Root Resource
  - Location - too narrow combo box
  - Representation Class - too narrow field
- Container-Item
  - Location - too narrow combo box
  - Resource Package - too narrow combo box
  - MIME Type - too narrow combo box
Comment 31 Jiri Skrivanek 2012-09-20 07:44:39 UTC
Created attachment 124618 [details]
Screen shots - from patterns - Linux - 20120920.
Comment 32 Denis Anisimov 2012-09-20 07:59:22 UTC
(In reply to comment #30)
> Great! Now all fields are visible. But sorry for nitpicking there are still
> some minor issues which definitely are easy to fix (see screen shots):
> - Simple Root Resource
>   - Location - too narrow combo box
>   - Representation Class - too narrow field
> - Container-Item
>   - Location - too narrow combo box
>   - Resource Package - too narrow combo box
>   - MIME Type - too narrow combo box

There are reasons why we don't collect all issues under one bug report.
In this specific case there are at least:
- The Summary of the bug is "Hidden Text Box during REST endpoint creation".
  I don't see how last issues relate to the original issue.
- The original issue is a patch candidate. It is important what is exactly about.
- All mentioned issues are minor as you noticed.
- This UI has not been changed for ages. So this is not a result of some recent
changes but old behavior.

So please file a different bug for found issues.
Comment 33 Jiri Skrivanek 2012-09-20 08:16:25 UTC
Verified and filed bug 218663 for remaining issues.
Comment 34 Denis Anisimov 2012-09-24 14:42:56 UTC
release72 branch 
web-main#08a29f2466d2
Comment 35 Marian Mirilovic 2012-09-25 05:17:50 UTC
I rolledback changes in release72 branch as it wasn't even compilable !
Comment 36 Denis Anisimov 2012-09-25 09:34:55 UTC
(In reply to comment #35)
> I rolledback changes in release72 branch as it wasn't even compilable !

Sorry.
27421ba24bcf
Comment 37 Quality Engineering 2012-09-25 11:06:11 UTC
Integrated into 'releases', will be available in build *201209250659* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/08a29f2466d2
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#214951 - Hidden Text Box during REST endpoint creation ( in release72 branch ).
Comment 38 Quality Engineering 2012-09-25 20:55:34 UTC
Integrated into 'releases', will be available in build *201209251619* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/27421ba24bcf
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#214951 - "Hidden Text Box during REST endpoint creation" in release72 branch.
Comment 39 Jiri Skrivanek 2012-09-26 13:01:26 UTC
It seems to me not transplanted correctly. Anyway it is acceptable for patch1. You probably forgot .form files. Please, compare content of all changed files in trunk with release72 branch

websvc.rest/src/org/netbeans/modules/websvc/rest/wizard
/ContainerItemSetupPanelVisual.form
/ContainerItemSetupPanelVisual.java
/JerseyPanel.form
/JerseyPanel.java
/PatternResourcesSetupPanel.java
/SingletonSetupPanelVisual.java

http://hg.netbeans.org/main-golden/rev/d25b7ff356d4
http://hg.netbeans.org/releases/rev/27421ba24bcf
Comment 40 Denis Anisimov 2012-09-26 13:30:10 UTC
(In reply to comment #39)
> It seems to me not transplanted correctly. Anyway it is acceptable for patch1.
> You probably forgot .form files. Please, compare content of all changed files
> in trunk with release72 branch
> 
> websvc.rest/src/org/netbeans/modules/websvc/rest/wizard
> /ContainerItemSetupPanelVisual.form
> /ContainerItemSetupPanelVisual.java
> /JerseyPanel.form
> /JerseyPanel.java
> /PatternResourcesSetupPanel.java
> /SingletonSetupPanelVisual.java
> 
> http://hg.netbeans.org/main-golden/rev/d25b7ff356d4
> http://hg.netbeans.org/releases/rev/27421ba24bcf

I didn't forget them. They are not required to fix the issue.
Comment 41 Jiri Skrivanek 2012-09-26 14:15:04 UTC
I tried build 201209251619 from release72 branch and it is OK there. Previously I tried build 7.2 with patch1 which probably doesn't contain this fix. I am sorry for false alarm.
Comment 42 Jiri Skrivanek 2012-10-04 09:15:53 UTC
Is spec. version of module increased?
Comment 43 Denis Anisimov 2012-10-04 09:58:08 UTC
(In reply to comment #42)
> Is spec. version of module increased?

Forgot to do it.
9ed6242f37a5