Bug 212364 - Malformed dot-separated identifier when artifactid contains dot separated numbers
Malformed dot-separated identifier when artifactid contains dot separated num...
Status: RESOLVED FIXED
Product: platform
Classification: Unclassified
Component: Netigso
7.2
PC Windows 7
: P2 (vote)
: 7.2
Assigned To: Jaroslav Tulach
issues@platform
: API_REVIEW_FAST
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-11 08:53 UTC by anttiko
Modified: 2012-05-24 05:49 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
:


Attachments
More flexible code name scheme (3.95 KB, patch)
2012-05-17 10:25 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anttiko 2012-05-11 08:53:35 UTC
Validation of artifactId which has dot separated numbers fails.

Example:
<dependency>
  <groupId>org.apache.servicemix.specs</groupId>
  <artifactId>org.apache.servicemix.specs.jsr-303-api-1.0.0</artifactId>
  <version>1.8.0</version>
</dependency>

This will cause exception:

java.lang.IllegalArgumentException: Malformed dot-separated identifier: org.apache.servicemix.specs.jsr303_api_1.0.0
  at org.openide.modules.Dependency.checkCodeName(Dependency.java:201)
  at org.openide.modules.Dependency.create(Dependency.java:275)
[catch] at org.netbeans.core.startup.ModuleList$ReadInitial.run(ModuleList.java:1610)
  at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:127)
  at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:607)
  at org.netbeans.core.startup.ModuleList.readInitial(ModuleList.java:171)
  at org.netbeans.core.startup.ModuleSystem.readList(ModuleSystem.java:281)
  at org.netbeans.core.startup.Main.getModuleSystem(Main.java:168)
  at org.netbeans.core.startup.Main.start(Main.java:305)
  at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:123)
  at java.lang.Thread.run(Thread.java:722)
Comment 1 Jaroslav Tulach 2012-05-17 10:25:11 UTC
To absorb the flexibility of OSGi symbolic names, we can either invent some mangling scheme or relax our code name rules. We are already mangling "-" into "_" and it requires mangling/demangling to be spread all over the code base. Rather then doing the same in this case, I propose to relax our rules to allow parts of the code name to start with numbers.
Comment 2 Jaroslav Tulach 2012-05-17 10:25:16 UTC
Created attachment 119563 [details]
More flexible code name scheme
Comment 3 Jaroslav Tulach 2012-05-22 15:47:14 UTC
Can I integrate tomorrow?
Comment 4 Jaroslav Tulach 2012-05-24 05:49:35 UTC
ergonomics#e43740414093


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo