This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 210746 - Refactoring not working in CSS
Summary: Refactoring not working in CSS
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.2
Hardware: PC Linux
: P2 normal (vote)
Assignee: Ralph Ruijs
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2012-04-05 07:06 UTC by Vladimir Riha
Modified: 2012-04-10 06:21 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2012-04-05 07:06:38 UTC 
Refactoring is not working in CSS files at all.

Steps to reproduce:
- create new css file (tested in php and java web project)
- paste some rule:

#menu{
    width: 700px;
    height: 51px;
    margin: 0 auto;
    margin-bottom: 30px;
}


- put caret inside the "#menu" and either press Ctrl+R or right click Refactor|Rename

=> result: Nothing happens, no dialog is opened. This works in 7.1.2


Product Version: NetBeans IDE Dev (Build 201204042200)
Java: 1.7.0_03; Java HotSpot(TM) Client VM 22.1-b02
System: Linux version 3.0.0-17-generic-pae running on i386; UTF-8; en_US (nb)
Comment 1 Vladimir Riha 2012-04-05 08:09:43 UTC 
Perhaps more like a P3...
Comment 2 Marek Fukala 2012-04-06 10:45:12 UTC 
reproducible, it worked a few builds before.
Comment 3 Marek Fukala 2012-04-06 11:14:27 UTC 
very likely caused by ralphbenjamin's change e2fe8fffc58a (issue #210346)

the custom CSS refactoring dialog is never show since now the ParametersPanel.placeCustomPanel() exits at the very beginning by if (dialog == null) {            return;        }
Comment 4 Ralph Ruijs 2012-04-06 13:38:57 UTC 
Sorry my fault, there is a wrongly translated logical condition. The mentioned if statement in placeCustomPanel is correct though. Will push a fix in a few minutes.
Comment 5 Ralph Ruijs 2012-04-06 13:48:55 UTC 
Changeset: c7a6d5a68740
Author:    Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Date:      2012-04-06 15:46
Message:   
Issue #210746 - Refactoring not working in CSS
Comment 6 Marek Fukala 2012-04-06 14:11:13 UTC 
Thank you!
Comment 7 Quality Engineering 2012-04-08 09:53:09 UTC 
Integrated into 'main-golden', will be available in build *201204080400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c7a6d5a68740
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: Issue #210746 - Refactoring not working in CSS
Comment 8 Vladimir Riha 2012-04-10 06:21:39 UTC 
verified, thanks

Product Version: NetBeans IDE Dev (Build 201204090400)
Java: 1.7.0_04-ea; Java HotSpot(TM) Client VM 23.0-b20
System: Linux version 3.0.0-17-generic-pae running on i386; UTF-8; en_US (nb)