This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Hi, I am opening this task to offer refactoring of groovy cluster to new @DataObject.Registration and some related cleaning (i.e. using constant) Some Loader related action will also be patched. I first need to have agreement of assignee to review change and then I will work on the patch.
Sure, I'll be more than happy to review your changes ;]
Created attachment 117509 [details] Convertion proposal of layer folder on cluster This patch concern the following module of the cluster groovy.editor groovy.grailsproject groovy.gsp groovy.support Action rewrite using annotation with messages anotation also. As groovy.editor use language annotation I was not able to completly remove the Loaders folder to keep icon (with blue star) usage. Seems that unit test of groovy.editor is broken but not sure I'am gulty :p. I am not using groovy so any regression (menu, visual placement)you may see please let me know ;p. PS: Fix 2 duplicated nbjunit present in project.xml to be sure not interfering with my build.
After applying your patch I can see one regression. GSP files (most probably related to groovy.gsp module) aren't recognized and thus language coloring, highlighting etc. isn't working.
Not sure if it might cause the problem but looking at diff, GspDataLoader is using DataObject.Registration annotation, but gsp language is also registered via @Language annotation (see GspLanguage class). Maybe we should move action registrations to GspLanguage in the same way as it is in GroovyLanguage?
Created attachment 117532 [details] Convertion proposal of layer folder on cluster I factorize more to avoid typo into the gsp module. I reintroduce the icon for gsp file. I install grails and I see all actions on gsp file and I can use autocompletion with color. (gsp appears to be kind of html to me).
Ok, new patch seems to me fine. Just one small cosmetic change - please delete the empty comment before GroovyProjectModule class declaration. Btw: I really like these changes :] .. annotations are so much readable than the old layer based code.
Oops, whiteboard was changed by mistake --> clearing it
Created attachment 117539 [details] Convertion proposal of layer folder on cluster Remove of the empty comment. PS: some of layer entry can be refactored to use Template annotation. (but to stay on topic I did not refactor them)
Great I'm totally satisfied with the last diff. Do you have privileges for pushing those changes or should I integrate them by myself?
I have not asked for this privilege yet :p you must push this change yourself.
Ok, I'm on it. Thanks a lot for your contribution!
Fixed in: web-main #a980fcca1932
Integrated into 'main-golden', will be available in build *201204040400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/a980fcca1932 User: Martin Janicek <mjanicek@netbeans.org> Log: #210382 - Convert groovy cluster to new @DataObject.Registration annotation