This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 209488 - Deprecated autoload org.openidex.util still enabled
Summary: Deprecated autoload org.openidex.util still enabled
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: API, ARCH
Depends on: 209514
Blocks: 207436
  Show dependency tree
 
Reported: 2012-03-12 17:49 UTC by Jesse Glick
Modified: 2012-03-28 15:46 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2012-03-12 17:49:10 UTC
After api.search was introduced, the old o.openidex.util is still in use, which ought to be unnecessary.


1. EditorModule should stop using SearchHistory and SearchPattern. I presume the copies from org.netbeans.api.search are intended to be used instead, so switch the editor -> o.openidex.util dep to -> api.search.


2. utilities.project uses it for compatibility. But this dependency could probably be inverted:

2a. Turn CompatibilityUtils into an interface, in a new package org.netbeans.modules.search.project.spi; check for an instance of CU in default lookup.

2b. Remove the utilities.project -> o.openidex.util dep.

2c. Export org.netbeans.modules.search.project.spi as a friend package to o.openidex.util, and make o.openidex.util depend on utilities.project.

2d. Implement CU in o.openidex.util, registering with @ServiceProvider.

Thus o.openidex.util would be enabled, and the compatibility bridge would be active, iff some module outside the NB IDE distribution were still using the old API.


3. Various modules still use org.openidex.util as test dependencies. (fgrep org.openidex.util */nbproject/project.xml)


4. Assuming #1 and #2 are implemented, 325be6f9057f should be reverted, so that ValidateModulesTest ensures no new attempts to use the module are introduced.
Comment 1 Jaroslav Havlin 2012-03-13 13:56:39 UTC
1. Fixed, editor uses the new API
   http://hg.netbeans.org/core-main/rev/faa0304d6b1e

2. Fixed, dependency on the old API inverted
   http://hg.netbeans.org/core-main/rev/b1b6bfe1094f

3. Unnecessary dependencies removed
   http://hg.netbeans.org/core-main/rev/0b7949e0702d

   Module cnd.makeproject still needs the deprecated API. Created bug 209514.
Comment 2 Jaroslav Havlin 2012-03-28 15:44:32 UTC
4. 325be6f9057f reverted
   http://hg.netbeans.org/core-main/rev/f49a9bd6c981