I would like to enhance ErrorDescription with an optional ID and "more details" text.
Created attachment 116594 [details]
Proposed API change.
Please review. Thanks.
The patch is OK.
[JG01] The createErrorDescription overloads are becoming unreadably long. Consider using the builder pattern for optional args, e.g.
ErrorDescription e = ErrorDescriptionFactory.make(WARNING, "Bad stuff!", doc, line).id("bad_stuff).details("There is bad stuff here.").fixes(oneFix, anotherFix);
JL01: I am thinking about converting the factory into a builder (possibly deprecating the whole ErrorDescriptionFactory and replacing it with ErrorDescriptionBuilder), but I would rather keep the change simple for now. If/when we move to to the builder pattern, deprecating three additional methods shouldn't be too difficult.
JG01 - OK.