This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 208762 - Excesive creation of regexp matchers in NetigsoModule
Summary: Excesive creation of regexp matchers in NetigsoModule
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 7.1
Hardware: PC Linux
: P2 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 17:52 UTC by Petr Hrebejk
Modified: 2012-02-26 11:16 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hrebejk 2012-02-22 17:52:08 UTC 
During installation of modules there are lot's of calls to NetigsoModule.getMainAttribute. Thousands of them. Due to the implementation based on regexp (String.replace) thousands of Matchers and Patterns are created, which is slow. The values in getMainAttribute and getCodeNameBase should probably be cached.
Comment 1 Jaroslav Tulach 2012-02-22 19:24:31 UTC 
ergonomics#c956d207a9a4
Comment 2 Quality Engineering 2012-02-26 11:16:06 UTC 
Integrated into 'main-golden', will be available in build *201202260400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c956d207a9a4
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #208762: Caching codeName and specification version. Not using regular expression to strip off ';.*'