This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 208653 - Brace completion infrastructure rewrite to typing hooks context
Summary: Brace completion infrastructure rewrite to typing hooks context
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 207609
  Show dependency tree
 
Reported: 2012-02-20 15:52 UTC by Milutin Kristofic
Modified: 2012-02-28 14:20 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Api Change with use case (83.56 KB, patch)
2012-02-20 16:32 UTC, Milutin Kristofic 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Milutin Kristofic 2012-02-20 15:52:27 UTC 
The current brace completion infrastructure java.editor/src/org/netbeans/modules/editor/java/BraceCompletion.java has methods which are called after insert.

Task #204450 rewrite actions to use TypingHooks SPI, where changes in document are done before insert. Therefore rewriting with use of BraceCompletion created bug #207609 - Brace completion regressions like undo problem.

There should be rewrite of BraceCompletion' methods from after insert behavior to before insert behavior and also to typing context.
Comment 1 Milutin Kristofic 2012-02-20 16:32:45 UTC 
Created attachment 115958 [details]
Api Change with use case

I rewrite BraceCompletion' methods and this involved following changes in editor.lib api:

- Change in assert to fix inserting empty text to TypedTextInterceptor.MutableContext
- Replace is done before perform insert, before typing hooks insert method
Comment 2 Milutin Kristofic 2012-02-27 14:33:08 UTC 
http://hg.netbeans.org/jet-main/rev/e9a6ebb16ec5