Bug 206783 - Factor Ant support out of org.netbeans.modules.junit
Factor Ant support out of org.netbeans.modules.junit
Product: java
Classification: Unclassified
Component: JUnit
All All
: P3 with 1 vote (vote)
: 8.1
Assigned To: Theofanis Oikonomou
Depends on:
Blocks: 166379 206441
  Show dependency treegraph
Reported: 2011-12-29 13:05 UTC by Jesse Glick
Modified: 2015-09-17 15:03 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT


Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-12-29 13:05:28 UTC
Investigating bug #206441 I found that maven.junit had to simply copy numerous node classes from junit, with the predictable subtle differences in behavior. The reason is that org.netbeans.modules.junit.output hardcodes support for Ant sessions but also includes the standard test node implementations, tied to the Ant implementation. I consider this an architectural defect.

You need to make JUnitTestRunnerNodeFactory into some kind of friend API that maven.junit can reuse, so that it need only supply JUnitOutputProcessorFactory (+ JUnitOutputListenerProvider) and perhaps a few minor customizations; then factor JUnitAntLogger and related classes in org.netbeans.modules.junit.output, plus all of org.netbeans.modules.junit.output.antutils, into a new module junit.ant (removing the o.apache.tools.ant.module dep from junit itself).

This will also be useful for permitting an alternate JavaRunner.QUICK_TEST impl based on extexecution rather than Ant.
Comment 1 Theofanis Oikonomou 2015-09-17 15:03:51 UTC
This should be more or less be fixed by http://hg.netbeans.org/main-silver/rev/a7f1d7823bf6. So closing this one. Thank you

By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo