This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 203995 - Cancel on dialog where all references were resolved
Summary: Cancel on dialog where all references were resolved
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Project (show other bugs)
Version: 7.1
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords:
: 203097 (view as bug list)
Depends on:
Blocks: 195942
  Show dependency tree
 
Reported: 2011-10-20 09:03 UTC by Martin Entlicher
Modified: 2011-11-10 15:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screenshot (15.06 KB, image/png)
2011-10-20 09:03 UTC, Martin Entlicher 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2011-10-20 09:03:06 UTC 
See the attached screenshot. After all reference problems were resolved, the dialog still shows Cancel button. This looks very strange. The button should be changed to Close.
Comment 1 Martin Entlicher 2011-10-20 09:03:49 UTC 
Created attachment 112248 [details]
Screenshot
Comment 2 Jesse Glick 2011-11-07 19:15:03 UTC 
I recall some similar issue filed recently (but without a screenshot). AFAIK the dialog is supposed to show (just) a "Close" button. BrokenReferencesSupport.showAlertImpl in fact creates a JButton 'close' but then does not use it; probably the two usages here of DialogDescriptor.CANCEL_OPTION should be replaced.


BTW the code

Dialog dlg = null;
try {
    dlg = DialogDisplayer.getDefault().createDialog(dd);
    dlg.setVisible(true);
} finally {
    if (dlg != null) {
        dlg.dispose();
    }
}

could probably be replaced with just

DialogDisplayer.getDefault().notify(dd);
Comment 3 Tomas Zezula 2011-11-09 08:35:41 UTC 
Fixed jet-main c45ea2765b05
Comment 4 Tomas Zezula 2011-11-09 08:36:43 UTC 
*** Bug 203097 has been marked as a duplicate of this bug. ***
Comment 5 Quality Engineering 2011-11-10 15:55:08 UTC 
Integrated into 'main-golden', will be available in build *201111100600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/c45ea2765b05
User: Tomas Zezula <tzezula@netbeans.org>
Log: #203995:Cancel on dialog where all references were resolved