This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 112178 [details] shelldataobject patch while fixing issue #200419 changes were made in the ShellDataObject (#1ae7060b5caa) to provide the History tab for shell scripts. Unfortunately, also the method assotiateLookup() had to be overridden to return 1 instead of the default 0. Otherwise the dataobjects lookup isn't properly setup and the result is that some actions in the editors context menu are disabled/misconfigured - e.g. the Diff to... action or all menu items in the Local History and Mercurial submenus. the same applies to MakefileDataObject, and probably also to other DataObjects changed because of the mentioned issue. see attached patch
Methods assotiateLookup() were overridden in change set: http://hg.netbeans.org/core-main/rev/1bb593b72bd5 But multi view editor has a problems with icons and persistence. For example I see warning in IDE log: INFO [org.netbeans.core.windows.persistence]: [PersistenceManager.getTopComponentForID] Problem when deserializing TopComponent for tcID:'MultiView-makefile#003DFFC0ADtext#002Ehistory#007C'. Reason: Top component MultiView-makefile#003DFFC0ADtext#002Ehistory#007C could not be located or loaded from Components folder. INFO [org.netbeans.core.windows.view.ui.TabbedHandler]: TopComponent has no icon: MVCTC[name=Makefile, peer=[model=current=org.netbeans.core.spi.multiview.MultiViewFactory$MapMVD@747ce6]] Reassign to evaluation.
(In reply to comment #1) > Methods assotiateLookup() were overridden in change set: > http://hg.netbeans.org/core-main/rev/1bb593b72bd5 Sorry, right change set: http://hg.netbeans.org/cnd-main/rev/503b226f1b76
> But multi view editor has a problems with icons and persistence. > For example I see warning in IDE log: is there something that doesn't work as expected, or is it just those messages? because the severity is info i was able to reproduce the icon message - appears when activating the "History" tab.Caused by the fact that the History tab provides no icon. Seems to be harmless. don't know how to reproduce the message coming from the PersistenceManager - might be caused by the History tabs pane being also a TopComponent. cc jarda - he might know better
(In reply to comment #3) > > But multi view editor has a problems with icons and persistence. > > For example I see warning in IDE log: > is there something that doesn't work as expected, or is it just those messages? > because the severity is info Yes, editor pane with makefile does not restored after IDE restarting, instable icon of editor pane - sometime absent and appear after switching between source-history.
> INFO [org.netbeans.core.windows.persistence]: > [PersistenceManager.getTopComponentForID] Problem when deserializing > TopComponent for tcID:'MultiView-makefile#003DFFC0ADtext#002Ehistory#007C'. > Reason: Top component MultiView-makefile#003DFFC0ADtext#002Ehistory#007C could > not be located or loaded from Components folder. hm, it's only with makefiles i'm able to reproduce this
(In reply to comment #5) > > INFO [org.netbeans.core.windows.persistence]: > > [PersistenceManager.getTopComponentForID] Problem when deserializing > > TopComponent for tcID:'MultiView-makefile#003DFFC0ADtext#002Ehistory#007C'. > > Reason: Top component MultiView-makefile#003DFFC0ADtext#002Ehistory#007C could > > not be located or loaded from Components folder. > hm, it's only with makefiles i'm able to reproduce this with other types of files instead of zero we get two tabs: https://netbeans.org/bugzilla/show_bug.cgi?id=202681
Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/503b226f1b76 User: Alexander Simon <alexvsimon@netbeans.org> Log: fixing Bug #203903 - override assotiateLookup() in ShellDataObject
> INFO [org.netbeans.core.windows.persistence]: > [PersistenceManager.getTopComponentForID] Problem when deserializing > TopComponent for tcID:'MultiView-makefile#003DFFC0ADtext#002Ehistory#007C'. > Reason: Top component MultiView-makefile#003DFFC0ADtext#002Ehistory#007C could > not be located or loaded from Components folder. is a bug in window system - see issue #203980
(In reply to comment #4) > instable icon of editor pane - sometime absent and appear after switching between > source-history. see issue #204072
It seems all sub-issues was fixed. Tomas, can I close bug as resolved?
feel free to close