This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 203326 - Downloading plugins that require restart, doesn't show the restart icon.
Summary: Downloading plugins that require restart, doesn't show the restart icon.
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Lookup (show other bugs)
Version: 7.1
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2011-10-07 19:25 UTC by javydreamercsw
Modified: 2011-11-04 15:06 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description javydreamercsw 2011-10-07 19:25:22 UTC
Product Version = NetBeans IDE Dev (Build 201110070600)
Operating System = Windows 7 version 6.1 running on x86
Java; VM; Vendor = 1.7.0
Runtime = Java HotSpot(TM) Client VM 21.0-b17

I just downloaded plugins that I know require restart but I didn't get the restart icon on the tray. Even after I restarted they don't seem to be active. For example the embedded browser doesn't open when clicking links in the Start>What's new. But they show as active in the plugin list.
Comment 1 Jiri Rechtacek 2011-10-10 16:17:36 UTC
What plugins do you mean? Anyway, in that case a external browser does open a link even though Plugins shows it's active. Not a problem of autoupdate but external browser. File an another bug about that. Thanks

Back to the problem with showing restart icon, it's a regression cause by solving issue 201745. As a easy workaround, run your IDE with a switch -J-Dplugin.manager.check.updates=true.
Comment 2 Jiri Rechtacek 2011-10-10 23:23:32 UTC
Jardo, something weird in lookup, Lookup.getDefault().lookup(NotificationDisplayer.class) returns different instances of NotificationDisplayerImpl.class after installing new modules (on the fly) via autoupdate. Due to property change event are lost in FlashingIcon in core/ui. It's a regression in NB7.1 I guess.

It's reproducible in latest nightly build:
  Product Version         = NetBeans IDE Dev (Build 201110100600) (#90cd7ea56413)
  Operating System        = Linux version 2.6.38-11-generic running on i386
  Java; VM; Vendor        = 1.6.0_26; Java HotSpot(TM) Client VM 20.1-b02; Sun Microsystems Inc.
  Runtime                 = Java(TM) SE Runtime Environment 1.6.0_26-b03
  Java Home               = /usr/local/share/java/jdk1.6.0_26/jre
Comment 3 Jaroslav Tulach 2011-10-11 15:23:24 UTC
Caused by fix of bug 200848.

*** This bug has been marked as a duplicate of bug 201544 ***
Comment 4 Jaroslav Tulach 2011-11-03 11:06:26 UTC
I was wrong assuming this bug is related to bug 200848. That one was about layers, this is about META-INF/services...

Anyway the whole assert thing is completely wrong: if you hold Integer hash code who will make sure the previous implementation will not garbage collect?
Comment 5 Jaroslav Tulach 2011-11-03 11:12:30 UTC
Some additional comments, this is sub-optimal:

    static NotificationDisplayerImpl getInstance() {
        NotificationDisplayer nd = Lookup.getDefault().lookup(NotificationDisplayer.class);
        if( nd instanceof NotificationDisplayerImpl )
            return (NotificationDisplayerImpl) nd;
        return null;
    }


use Lookup.getDefault().lookup(NotificationDisplayerImpl.class). Don't forget to register the @ServiceProvider(service=NotificationDisplayerImpl.class) in addition to current @ServiceProvider(service=NotificationDisplayer.class)
Comment 6 Stanislav Aubrecht 2011-11-03 13:57:48 UTC
core-main cd861f06eacd
Comment 7 Quality Engineering 2011-11-04 15:06:06 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/cd861f06eacd
User: S. Aubrecht <saubrecht@netbeans.org>
Log: #203326 - Downloading plugins that require restart, doesn't show the restart icon