This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 202277 - Esc key doesn't close search/replace panels if focus is not on a panel field.
Summary: Esc key doesn't close search/replace panels if focus is not on a panel field.
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Search (show other bugs)
Version: 7.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords:
Depends on:
Blocks: 212714
  Show dependency tree
 
Reported: 2011-09-19 05:53 UTC by paolosca
Modified: 2012-08-25 02:47 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description paolosca 2011-09-19 05:53:46 UTC
Product Version: NetBeans IDE Dev (Build 201109180600)
Java: 1.6.0_26; Java HotSpot(TM) Client VM 20.1-b02
System: Linux version 3.0.0-1-686-pae running on i386; UTF-8; en_US (nb)
User directory: /home/paolo/.netbeans/dev
Cache directory: /run/netbeans

I noticed that I can use the esc key to close the search/replace panels only if the focus is in one of the panels fields.

If I'm not mistaken, when the search/replace functions were on floating windows it was possible to always close them using the esc key.

Steps to reproduce:

1. Press ctrl+f or ctrl+h;
2. Type anything;
3. Pressing the esc key will close the panel;

1. Press ctrl+f or ctrl+h;
2. Type anything;
3. Click on the editor
4. Pressing the esc key will not close the panel;

If this is not considered a bug, please change it to enhancement request because it's a lot more comfortable to be able to close the panel just using the keyboard.

Regards,

Paolo.
Comment 1 Milutin Kristofic 2011-10-04 09:44:09 UTC
I think it would be irresponsible, if I take esc key in whole netbeans or in editor for closing search/replace bar. Esc key is too much important. 

It is also not working in firefox, it was not working with old find/replace dialogs. If you don't believe me, you can try to go to diff in netbeans and with ctrl + f - you open old find dialog. If you change focus to editor, it will be not closed. Only change is that searchbar was closed automatically when you changed focus. But find dialog was not.
Comment 2 paolosca 2011-10-08 05:26:32 UTC
Yes, at second thought you are right. I tested some more editors and in all of them the esc key closes the search dialog only if the focus is on the dialog it self.

I think what confused me is that in other editors the search is made through a floating window which can get the focus just by clicking on it. That means, clicking anywhere on the dialog window will turn the focus on it and it can then be closed using the esc key.

Since in NetBeans this is done through a panel which can't get the focus, clicking on the panel itself doesn't allow the user to close it with the esc key. To do so the user have to click on one of the data fields in the panel (i.e. the Find field).

Probably I didn't get completely used to the panel layout yet, sorry for wasting your time.

Have a nice day,

Paolo
Comment 3 Milutin Kristofic 2011-10-10 07:53:59 UTC
Yes, you are right. I am closing search panel by calling again ctrl+f and then Esc key.
Comment 4 Milutin Kristofic 2011-11-14 14:22:37 UTC
I will implement a function close find/replace bar and in keymap you can match escape for it.
Comment 5 paolosca 2011-11-24 09:14:25 UTC
(In reply to comment #4)
> I will implement a function close find/replace bar and in keymap you can match
> escape for it.

Thank you, that will be very useful.

Regards,

Paolo
Comment 6 Milutin Kristofic 2012-05-17 13:58:32 UTC
Unfortunately, escape infrastructure was not finished to 7.2. But it is planned to 7.3
Comment 7 Milutin Kristofic 2012-08-21 16:05:42 UTC
http://hg.netbeans.org/jet-main/rev/5a763184468e
Comment 8 Quality Engineering 2012-08-25 02:47:55 UTC
Integrated into 'main-golden', will be available in build *201208250001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/5a763184468e
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #202277 - Esc key doesn't close search/replace panels if focus is not on a panel field.