This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 201399 - API Review for IntroduceParameterRefactoring
Summary: API Review for IntroduceParameterRefactoring
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.1
Hardware: All All
: P3 normal (vote)
Assignee: Ralph Ruijs
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2011-08-29 14:59 UTC by Ralph Ruijs
Modified: 2011-09-07 14:28 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Proposed patch (3.47 KB, patch)
2011-08-29 15:01 UTC, Ralph Ruijs 		Details | Diff
Related class (6.71 KB, text/plain)
2011-08-29 15:23 UTC, Ralph Ruijs 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Ruijs 2011-08-29 14:59:12 UTC 
The IntroduceParameterRefactoring class is already in trunk but, as it has public API, it should have been reviewed.

This api adds support for a new Java Refactoring to introduce a new parameter from an expression or a variable declaration. The attached patch shows the concerning files and adds the necessary @since tags.

Please review the api and attached patch.
Comment 1 Ralph Ruijs 2011-08-29 15:01:35 UTC 
Created attachment 110266 [details]
Proposed patch
Comment 2 Ralph Ruijs 2011-08-29 15:23:29 UTC 
Created attachment 110267 [details]
Related class
Comment 3 Ralph Ruijs 2011-09-05 07:41:52 UTC 
Will push the last changes tomorrow.
Comment 4 Ralph Ruijs 2011-09-06 12:13:15 UTC 
Changeset: 85289b33a34f
Author:    Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Date:      2011-09-06 14:08
Message:   Issue #201399 - API Review for IntroduceParameterRefactoring
Comment 5 Quality Engineering 2011-09-07 14:28:52 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/85289b33a34f
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: Issue #201399 - API Review for IntroduceParameterRefactoring