This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199830 - Incorrect events.wstcref
Summary: Incorrect events.wstcref
Status: RESOLVED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 7.1
Hardware: PC Linux
: P2 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 18:02 UTC by Jesse Glick
Modified: 2011-07-13 13:58 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-07-01 18:02:15 UTC
WARNING [org.netbeans.core.windows.persistence]: [WinSys.TCRefParser.handleTcId] Error: Value of attribute "id" of element "tc-id" and configuration file name must be the same.
INFO [org.netbeans.core.windows.persistence.ModeParser]
org.xml.sax.SAXException: Invalid attribute value
	at org.netbeans.core.windows.persistence.TCRefParser$PropertyHandler.handleTcId(TCRefParser.java:371)
	at org.netbeans.core.windows.persistence.TCRefParser$PropertyHandler.startElement(TCRefParser.java:281)
	at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:501)
	at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:179)
	at com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator.emptyElement(XMLDTDValidator.java:788)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511)
	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808)
	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737)
	at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119)
	at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205)
	at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522)
	at org.netbeans.core.windows.persistence.TCRefParser$PropertyHandler.readData(TCRefParser.java:247)
Caused: java.io.IOException: Cannot parse configuration of TCRef MultiFileObject@c2a17a[Windows2/Modes/output/events.wstcref].
	at org.netbeans.core.windows.persistence.TCRefParser$PropertyHandler.readData(TCRefParser.java:254)
	at org.netbeans.core.windows.persistence.TCRefParser.load(TCRefParser.java:106)
[catch] at org.netbeans.core.windows.persistence.ModeParser.readTCRefs(ModeParser.java:319)

In fact debugger.jpda.visual/src/org/netbeans/modules/debugger/jpda/visual/resources/events.wstcref specifies <tc-id id="eventsView" />, which is wrong.

Why are you writing these files by hand anyway? Use @TopComponent.Registration instead and you can dispense with <folder name="Windows2"> in your layer.

(You should also be using @ActionRegistration for ScreenshotGrabAction.)
Comment 1 Martin Entlicher 2011-07-11 13:48:25 UTC
I've forgot to adjust the registration name, I'll correct this.
It's a copy of settings from spi.debugger.ui/src/org/netbeans/modules/debugger/resources/modes/output/ folder, which can not be replaced with annotations, since there's just one TopComponent implementation class for all of them.
I want to keep that flexibility in this class as well and I can not use @TopComponent.Registration annotation on methods (see issue #200048).

I'll use the annotation for the ScreenshotGrabAction...
Comment 2 Martin Entlicher 2011-07-12 11:56:51 UTC
Fixed by changeset:   196893:e1e24c972ab0
http://hg.netbeans.org/main/rev/e1e24c972ab0
Comment 3 Jesse Glick 2011-07-12 15:10:09 UTC
(In reply to comment #1)
> I want to keep that flexibility in this class as well

Why? There is only one place where View is constructed. There is no apparent reason why you would want to introduce additional constructors for it. Even if you did later want to add another similar but distinct singleton TC, it would be clearer to just factor out the common behavior into an abstract superclass.
Comment 4 Quality Engineering 2011-07-13 13:58:35 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/e1e24c972ab0
User: mentlicher@netbeans.org
Log: #199830 Corrected file name eventsView.wstcref, ScreenshotGrabAction is registered via annotations.