This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199338 - Refactoring does not complete
Summary: Refactoring does not complete
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Code Model (show other bugs)
Version: 7.1
Hardware: PC All
: P2 normal (vote)
Assignee: Vladimir Voskresensky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-10 10:44 UTC by Alexander Pepin
Modified: 2011-06-19 06:41 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pepin 2011-06-10 10:44:12 UTC
Steps to reproduce:
- open clucene project
- open Classes view, it contains "lucene" namespace
- open StdHeader.h containing macroses to define namespaces
- manually change all "lucene" to "lucene1" then save the file, Classes view now shows "lucene1" namespace
- set cursor on "lucene1" in StdHeader.h and call Rename (Ctrl+R)
- in Rename dialog change "lucene1" back to "lucene1" and press Enter
Result:The namespace is renamed in StdHeader.h but Classes view shows both "lucene" and "lucene1" namespaces and they both contain some classes. It looks like renaming is not done completely. To complete refactoring a user should do any changes in StdHeader.h (e.g. insert a space symbol somewhere) and save the file.
Comment 1 Vladimir Voskresensky 2011-06-14 12:59:02 UTC
confirmed on Solaris. Can not reproduce on Linux. Probably file events are different
Comment 2 Vladimir Voskresensky 2011-06-14 14:01:42 UTC
More details:
- refactoring itself changes code correctly, so clean&&build is successful
- Reparse Project from context menu helps as well
Looks like either incorrect set of files is reparsed
Comment 4 Vladimir Kvashin 2011-06-17 11:29:04 UTC
I reviewed the fix. It looks correct and safe.
Comment 5 Alexander Pepin 2011-06-17 12:45:18 UTC
verified in trunk build 201106170600
Comment 7 Quality Engineering 2011-06-17 14:38:38 UTC
Integrated into 'main-golden', will be available in build *201106170600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/6ca7d358087c
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: trace to fix #199338 -  Refactoring does not complete
Comment 8 Quality Engineering 2011-06-19 06:41:19 UTC
Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/20ad5edc3b05
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: trace to fix #199338 -  Refactoring does not complete
(transplanted from 6ca7d358087c453b3192596e60c968de30cab4a7)