This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199083 - DialogDisplayerImpl doesn't reflect isLeaf() for NotifyDescriptor instances
Summary: DialogDisplayerImpl doesn't reflect isLeaf() for NotifyDescriptor instances
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 7.0.1
Hardware: PC Linux
: P2 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks: 197891
  Show dependency tree
 
Reported: 2011-06-01 13:27 UTC by Martin Fousek
Modified: 2011-06-14 04:58 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
patch (2.60 KB, patch)
2011-06-01 13:27 UTC, Martin Fousek
Details | Diff
Scatch of a unit test (10.05 KB, patch)
2011-06-08 09:07 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fousek 2011-06-01 13:27:31 UTC
Created attachment 108654 [details]
patch

DialogDisplayerImpl contains issue which was detected by fixing issue #197802. It seems that DialogDisplayerImpl.showDialog() doesn't care about NbPresenter.currentModalDialog.isLeaf() property for NotifyDescriptors. 

It causes i.e. that every invoked NotifyDescriptors by project opening is hidden together with finished opening of project. 

I'm attaching some patch for core.windows and projectui which should fix that. But I'm not sure why DialogDisplayerImpl.showDialog() differs between DialogDescriptor and others so it's possible that there could be one code for all cases. The short change for projectui is just creating DD as a leaf.

Thanks in advance for fixing that. BTW, it has to be fixed in the same release as #197802 - means 7.0.1.
Comment 1 Petr Jiricka 2011-06-02 15:01:25 UTC
This problem blocks P2 issue 197891, so I am raising this to P2 as well.
Comment 2 Jaroslav Tulach 2011-06-08 09:07:26 UTC
Created attachment 108795 [details]
Scatch of a unit test
Comment 3 Jaroslav Tulach 2011-06-08 12:55:57 UTC
ergonomics#4a9e97a78e16
Merged to release701 as 64143ef511d0
Comment 4 Quality Engineering 2011-06-11 15:15:50 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/4a9e97a78e16
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #199083: NotifyDescriptor.isLeaf works also for notify(...). Fix contributed by Martin Fousek. Test written by me.
Comment 5 Martin Fousek 2011-06-13 06:27:44 UTC
Verified in trunk. Thanks Jardo.
Comment 6 Quality Engineering 2011-06-14 04:58:24 UTC
Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/4a9e97a78e16
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #199083: NotifyDescriptor.isLeaf works also for notify(...). Fix contributed by Martin Fousek. Test written by me.