This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 197919 - various problems of source naviation
Summary: various problems of source naviation
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Code Model (show other bugs)
Version: 7.0
Hardware: All All
: P3 normal (vote)
Assignee: Vladimir Voskresensky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 21:27 UTC by Thomas Preisler
Modified: 2011-07-26 13:36 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Preisler 2011-04-20 21:27:04 UTC
From CR 7038036:

navigation does not go to implementation of virtual function

I used D&D to create dbx project from following binary :

/net/<see CR 7038036>/dbx

Problem 1. 
  some instances missing in search box (upper right corner of IDE),
  with * All Categories I type in get_event, a lot of instances pop-up,
  but not the one I want : 

	get_event(PcsEvent *pe) in pcsPD in pcsPD.cc

Problem 2. 
  select instances in search box lead me to function declaration, not
  function definition

  so I choose get_event(PcsEvent *pe) in LwpPD in pcsPD.cc, it show me line 536
   which is a function declaration (pretty much useless), not function definition

	virtual bool
		get_event(struct PcsEvent *pe);

Problem 3. 
  double click to hight light "get_event", bring up context menu, choose " Go to
  Implementation", a balloon show up "Lwp:get_Event" with a red dot, click on the
  red dot, it brought me to pcs.h:460, which again, virtual function declaration,
  
  virtual bool
		get_event(struct PcsEvent *pe) = 0;

  click on the grey dot (Is Overridden), bring me back to pcsPD.cc:536, click on
  green dot (Overrides Lwp:get_Event), bring me back to  pcs.h:460
*** (#1 of 1): 2011-04-19 19:18:20 PDT chihin.ko
Comment 1 Alexander Simon 2011-04-22 08:58:06 UTC
Go to implementation was replaced on Go to sub/super declaration.
IMHO it is regression.
Reassign to evaluation.
Comment 2 Vladimir Voskresensky 2011-04-22 15:19:08 UTC
(In reply to comment #1)
> Go to implementation was replaced on Go to sub/super declaration.
> IMHO it is regression.
> Reassign to evaluation.
No true.
Go to implementation is new action. I will rename it to "Go to Override/Overridden"
Comment 3 Vladimir Voskresensky 2011-04-22 15:28:44 UTC
(In reply to comment #0)
> From CR 7038036:
> 
> navigation does not go to implementation of virtual function
> 
> I used D&D to create dbx project from following binary :
> 
> /net/<see CR 7038036>/dbx
> 
> Problem 1. 
>   some instances missing in search box (upper right corner of IDE),
>   with * All Categories I type in get_event, a lot of instances pop-up,
>   but not the one I want : 
> 
>     get_event(PcsEvent *pe) in pcsPD in pcsPD.cc
1) you can use dedicated Navigate->Go to Symbol  to open special dialog for such search and it shows what you'd like to see
2) in your case you can see what you'd like if press "..."

> 
> Problem 2. 
>   select instances in search box lead me to function declaration, not
>   function definition
> 
>   so I choose get_event(PcsEvent *pe) in LwpPD in pcsPD.cc, it show me line 536
>    which is a function declaration (pretty much useless), not function
> definition
> 
>     virtual bool
>         get_event(struct PcsEvent *pe);
This is exactly because you have chosen function declaration, not function definition entry. Select function definition entry and you'll jump there.

> 
> Problem 3. 
>   double click to hight light "get_event", bring up context menu, choose " Go
> to
>   Implementation", a balloon show up "Lwp:get_Event" with a red dot, click on
> the
>   red dot, it brought me to pcs.h:460, which again, virtual function
> declaration,
> 
>   virtual bool
>         get_event(struct PcsEvent *pe) = 0;
> 
>   click on the grey dot (Is Overridden), bring me back to pcsPD.cc:536, click
> on
>   green dot (Overrides Lwp:get_Event), bring me back to  pcs.h:460
I agree - the name is bad. Will change it to "Go to Override/Overridden"
Also changed name "Go to Declaration" to be "Go to Declaration/Definition" because the same action jumps between decl definition.
http://hg.netbeans.org/cnd-main/rev/dc08776b3942

Btw, you don't need context menu. Just ctrl+click on declaration and you would jump into definition. Ctrl+click on definition and you'll jump to declaration
Comment 4 Quality Engineering 2011-04-23 04:37:57 UTC
Integrated into 'main-golden', will be available in build *201104230000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/dc08776b3942
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: fixed #197919 -  various problems of source naviation