This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 197512 - "Move inner to outer level" looses javadoc comments
Summary: "Move inner to outer level" looses javadoc comments
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Source (show other bugs)
Version: 7.0
Hardware: PC Windows XP
: P3 normal (vote)
Assignee: Jan Lahoda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 20:10 UTC by err
Modified: 2011-04-28 05:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description err 2011-04-06 20:10:28 UTC
In the following, the javadoc for the constructor is lost.
In version 7.0RC1

===
=== Before
===
    /**
     * This specifies a translation for the map command.
     * The translations occur during typebuf getChar processing.
     */
    public static class Mapping {
        String lhs;
        String rhs;
        int mode;
        boolean noremap;
        boolean isUnmap;
        boolean isHidden;

        /**
         * Define a mapping.
         * @param lhs from
         * @param rhs to
         * @param mode which mode(s) the mapping applies to
         * @param noremap if true the rhs should not be scanned for mappings
         */
        public Mapping(String lhs, String rhs, int mode, boolean noremap)
        {
            this.lhs = lhs;
            this.rhs = rhs;
            this.mode = mode;
            this.noremap = noremap;
        }

        /**
         * @return the vim mode(s) for which the mapping is valid
         */
        public int getMode()
        {
            return mode;
        }

===
=== After
===
/**
 * This specifies a translation for the map command.
 * The translations occur during typebuf getChar processing.
 */
/**
 *
 * @author Ernie Rael <err at raelity.com>
 */
public class Mapping {
    String lhs;
    String rhs;
    int mode;
    boolean noremap;
    boolean isUnmap;
    boolean isHidden;

    public Mapping(String lhs, String rhs, int mode, boolean noremap)
    {
        this.lhs = lhs;
        this.rhs = rhs;
        this.mode = mode;
        this.noremap = noremap;
    }

    /**
     * @return the vim mode(s) for which the mapping is valid
     */
    public int getMode()
    {
        return mode;
    }
Comment 1 Jan Becicka 2011-04-07 12:51:01 UTC
It looks like GeneratorUtilities.importComments does copy javadoc comments for methods, but does not copy javadoc comments for constructors.
Comment 2 Jan Lahoda 2011-04-19 14:34:44 UTC
TreeMaker.setLabel did not copy the comments, although it should, IMO:
http://hg.netbeans.org/jet-main/rev/3a9129acfce4
Comment 3 Quality Engineering 2011-04-27 04:49:34 UTC
Integrated into 'main-golden', will be available in build *201104270000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/3a9129acfce4
User: Jan Lahoda <jlahoda@netbeans.org>
Log: #197512: TreeMaker.setLabel should also copy comments.
Comment 4 Quality Engineering 2011-04-28 05:08:42 UTC
Integrated into 'main-golden', will be available in build *201104280000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/3a9129acfce4
User: Jan Lahoda <jlahoda@netbeans.org>
Log: #197512: TreeMaker.setLabel should also copy comments.