This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 195215 - Package private modifier in replaceProvidedLookup method that must be protected in org.openide.nodes.Node
Summary: Package private modifier in replaceProvidedLookup method that must be protect...
Status: RESOLVED INVALID
Alias: None
Product: platform
Classification: Unclassified
Component: Nodes (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal with 1 vote (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: API
Depends on:
Blocks:
 
Reported: 2011-02-09 04:49 UTC by DanielDLC
Modified: 2011-02-09 16:56 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DanielDLC 2011-02-09 04:49:59 UTC 
The Package private modifier in replaceProvidedLookup method is set, and that one must be protected in org.openide.nodes.Node

The designer considered the replace of the provided lookup by subclasses of node, but this is not possible since others packages. And to achive this behavior, mean tricky a lot the code.

I found this kind of issue in others classes of the APIs too.
Comment 1 Jesse Glick 2011-02-09 14:36:54 UTC 
The only known use case is in FilterNode. Otherwise you would simply pass whatever Lookup you like to the super constructor. An API review needs to include not just a proposed patch to API code (plus specification version increment, Javadoc, apichanges.xml edit, and any other miscellaneous changes needed for the final commit) but a complete explanation of what use cases are impossible (or impractical) without it. By "explanation" I mean either proposed patches to other parts of nb.org code which would use the API, or - if all the known use cases are in external modules - proposed patches to offsite code or self-contained example module projects which would benefit.
Comment 2 Jaroslav Tulach 2011-02-09 16:56:30 UTC 
The code in Node needs to know in advance whether it shall create lookup that delegates to getCookie or not. That is the reason why I require the lookup to be specified in constructor and then remain unchangable.