Bug 194545 - Constructors for LayerGenerationException specifying responsible annotation
Constructors for LayerGenerationException specifying responsible annotation
Status: RESOLVED FIXED
Product: platform
Classification: Unclassified
Component: Filesystems
6.x
All All
: P4 (vote)
: 7.1
Assigned To: Jesse Glick
issues@platform
: API, API_REVIEW_FAST
Depends on:
Blocks: 149136 196452
  Show dependency treegraph
 
Reported: 2011-01-20 20:42 UTC by Jesse Glick
Modified: 2011-07-27 14:09 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
:


Attachments
Running patch ('hg pdi LayerGenerationException_194545' to refresh) (77.50 KB, patch)
2011-07-18 22:23 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-01-20 20:42:46 UTC
See bug #149136 comment #29 and the patch it refers to. While it would not be thrown directly from LayerBuilder utility methods, there are other places where processors throw LGE themselves and it would be useful to specify the particular annotation so as to produce better error links.
Comment 1 Jesse Glick 2011-07-18 22:23:30 UTC
Created attachment 109496 [details]
Running patch ('hg pdi LayerGenerationException_194545' to refresh)
Comment 2 Jesse Glick 2011-07-18 22:27:53 UTC
Please review this proposed patch. It makes it possible to specify more precisely where an AP error occurred. (It is up to the Messager impl to take advantage of this information in producing more accurate line numbers.)

Note that the Annotation parameter is currently only searched for among direct annotations of the element, but this is used rather than Class<? extends Annotation> to allow an enhanced impl to find nested annotations; see commented-out test case.
Comment 3 Jesse Glick 2011-07-25 21:02:10 UTC
core-main #3ed7b437317d
Comment 4 Quality Engineering 2011-07-27 14:09:34 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/3ed7b437317d
User: Jesse Glick <jglick@netbeans.org>
Log: #194545: constructors for LayerGenerationException specifying responsible annotation.


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo