This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 19422 - No Accessible description for Java Help frame
Summary: No Accessible description for Java Help frame
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Help System (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: A11Y
Depends on:
Blocks:
 
Reported: 2002-01-14 16:49 UTC by Marian Mirilovic
Modified: 2008-12-23 13:37 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Patch applied in trunk, proposed for release33 branch (3.54 KB, patch)
2002-01-15 12:26 UTC, Jesse Glick
Details | Diff
Patch JAR (lib/patches/), should work in trunk build, probably also in r33 build (43.33 KB, application/octet-stream)
2002-01-15 13:57 UTC, Jesse Glick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Mirilovic 2002-01-14 16:49:30 UTC
[nb331_dev](20020114), [jdk1.3.1](02)

No Accessible description :
   Class: javax.swing.JFrame {  Help - All |  } 

No Accessible description for Java Help frame is reason for Priority P2 - this
must be fixed to 3.3.1.
Another A11Y issue of Java Help first testing see issue 19421
Comment 1 Patrick Keegan 2002-01-14 17:27:52 UTC
I guess you could look at this, Jesse?
Comment 2 Jesse Glick 2002-01-14 21:07:35 UTC
OK. Does there need to be an accessible description on the viewer as a
JDialog too? I suppose so.
Comment 3 Marian Mirilovic 2002-01-15 08:51:10 UTC
Yes, it is. We must give Accessible description for windows (JFrames,
JDialogs, JInternalFrames, .). Accessible Description describes window
contains more prolegomenous.

Shall I assigne this issue to rbrinkley too ?
Comment 4 brinkley 2002-01-15 09:24:01 UTC
If I rember correctly Netbeans creates it's own JFrame for help within
the JavaHelp module so this would be a Netbeans issue not a JavaHelp
issue. If that isn't the case let me know what needs to be fixed in
JavaHelp to address this issue.

binky
Comment 5 Jesse Glick 2002-01-15 12:03:35 UTC
committed   * Up-To-Date  1.321      
core/src/org/netbeans/core/Bundle.properties
committed   * Up-To-Date  1.51       
core/src/org/netbeans/core/JavaHelp.java

Should be fixed in the trunk. Marian, it would be great if you could
test that it is OK now - otherwise if I should get the A11Y tools and
check myself, I can do that. I will attach the diff, please check that
it looks right so I can get this into 3.3.1.
Comment 6 Jesse Glick 2002-01-15 12:26:45 UTC
Created attachment 4167 [details]
Patch applied in trunk, proposed for release33 branch
Comment 7 Marian Mirilovic 2002-01-15 12:58:40 UTC
Thanks, Jesse.

Could you attach a patch, last your attachment is diff, and I test it.
Thanks in advance.
Comment 8 Jesse Glick 2002-01-15 13:57:48 UTC
Created attachment 4169 [details]
Patch JAR (lib/patches/), should work in trunk build, probably also in r33 build
Comment 9 Marian Mirilovic 2002-01-15 14:30:06 UTC
I tested patch with todays build [nb_331_rc1](200201150331) and the
Accessible Description of Help window isn't null.

Thanks Jesse, it looks like good.
Comment 10 Jesse Glick 2002-01-15 15:21:36 UTC
OK, waiting for merge approval.

Marian I guess you want to mark this VERIFIED?
Comment 11 Marian Mirilovic 2002-01-15 15:28:22 UTC
I am waiting for official build (main-trunk or release33).
Comment 12 Marian Mirilovic 2002-01-15 15:36:21 UTC
Ok, you are right.

Patch VERIFIED.
Comment 13 Jan Chalupa 2002-01-15 15:41:33 UTC
Approved by QA.
Comment 14 Jesse Glick 2002-01-15 15:45:13 UTC
Whoops, I guess milestone should be 3.4 for the query page to find
this one.
Comment 15 iformanek 2002-01-16 09:17:04 UTC
Approved
Comment 16 eadams 2002-01-16 10:16:25 UTC
Approved.
Comment 17 _ ttran 2002-01-16 10:20:07 UTC
Jesse, I agree for the fix to go in 3.3.1.  Don't forget to change
target milestone to "3.3.1" after integration
Comment 18 Jesse Glick 2002-01-16 12:33:43 UTC
Merged:

committed   * Up-To-Date  1.318.2.9  
core/src/org/netbeans/core/Bundle.properties
committed   * Up-To-Date  1.50.2.1   
core/src/org/netbeans/core/JavaHelp.java
Comment 19 Marian Mirilovic 2002-01-18 09:45:20 UTC
verified in [nb3.3.1-rc2](200201180727)
Comment 20 Quality Engineering 2003-07-01 16:46:13 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.