This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 191842 - Multiple Sources exists for single FileObject
Summary: Multiple Sources exists for single FileObject
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Parsing & Indexing (show other bugs)
Version: 7.0
Hardware: All All
: P2 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 185714 189889
  Show dependency tree
 
Reported: 2010-11-11 12:24 UTC by Tomas Zezula
Modified: 2010-11-14 06:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2010-11-11 12:24:11 UTC 
The PHP support is slowed down by multiple Sources (SourceCaches, Parsers, Results) existing for single FileObject.
Comment 1 Tomas Zezula 2010-11-11 12:31:31 UTC 
Fixed jet-main afecafba372e
Comment 2 Petr Jiricka 2010-11-11 14:57:40 UTC 
Marian and I discussed whether this could be put into the beta, but Tomas says it is somewhat risky and he is not confident about the patch. How can it be verified that this did not break anything?
Comment 3 Marian Mirilovic 2010-11-11 15:02:08 UTC 
Ok, if I understand it correctly :
- this is fixing just part of the slowness reported in issue 185714
- this fix itself is risky and we haven't tested it yet (and it will rise testing of wide area)

If the above is correct, I vote against integration into NB 7.0 Beta, and leave it only in the trunk.
Comment 4 Tomas Zezula 2010-11-11 15:04:09 UTC 
By testing. I believe that the recreation of the Source is not needed, but someone should try.
The testers should do (open java| parsing-api) files during scan. Do changes to it after the scan.
Are the sources valid (the changes are visible)?
Comment 5 Quality Engineering 2010-11-14 06:23:03 UTC 
Integrated into 'main-golden', will be available in build *201011140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/afecafba372e
User: Tomas Zezula <tzezula@netbeans.org>
Log: #191842:Multiple Sources exists for single FileObject