This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 191732 - Ruby, Groovy, PHP Kits loaded for JavaSE project by Preformating65
Summary: Ruby, Groovy, PHP Kits loaded for JavaSE project by Preformating65
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Formatting & Indentation (show other bugs)
Version: -S1S-
Hardware: Other Linux
: P2 normal (vote)
Assignee: Dusan Balek
URL:
Keywords: PERFORMANCE, REGRESSION
Depends on:
Blocks:
 
Reported: 2010-11-08 14:51 UTC by Jaroslav Tulach
Modified: 2010-11-12 15:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Here are the allocation stack traces for all the current violators (692.31 KB, application/xml)
2010-11-08 14:56 UTC, Jaroslav Tulach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2010-11-08 14:51:07 UTC
Read http://wiki.netbeans.org/FitnessViaWhiteAndBlackList
and change your code to not intitialize various EditorKits for no reason.


      <violator class="org.netbeans.modules.ruby.rhtml.editor.RhtmlKit">
        <stacktrace instantiator="SystemClassLoader[692 modules]">
          org.netbeans.test.ide.BlacklistedClassesHandlerSingleton.publish(BlacklistedClassesHandlerSingleton.java:368)
          java.util.logging.Logger.log(Logger.java:458)
          java.util.logging.Logger.doLog(Logger.java:480)
          java.util.logging.Logger.log(Logger.java:544)
          org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:191)
          org.netbeans.ModuleManager$SystemClassLoader.loadClass(ModuleManager.java:547)
          java.lang.ClassLoader.loadClass(ClassLoader.java:252)
          org.openide.loaders.InstanceSupport.findClass(InstanceSupport.java:496)
          org.openide.loaders.InstanceSupport.instanceClass(InstanceSupport.java:148)
          org.openide.loaders.InstanceDataObject$Ser.instanceClass(InstanceDataObject.java:1313)
          org.openide.loaders.InstanceDataObject.instanceClass(InstanceDataObject.java:788)
          org.netbeans.modules.editor.impl.KitsTrackerImpl.instanceClass(KitsTrackerImpl.java:374)
          org.netbeans.modules.editor.impl.KitsTrackerImpl.updateAndGet(KitsTrackerImpl.java:525)
          org.netbeans.modules.editor.impl.KitsTrackerImpl.findKitClass(KitsTrackerImpl.java:154)
          org.netbeans.modules.editor.deprecated.pre65formatting.LegacyFormattersProvider$IndentReformatTaskFactoriesProvider.get(LegacyFormattersProvider.java:153)
          org.netbeans.modules.editor.deprecated.pre65formatting.LegacyFormattersProvider.getLookup(LegacyFormattersProvider.java:90)
          org.netbeans.modules.editor.mimelookup.MimePathLookup.rebuild(MimePathLookup.java:128)
          org.netbeans.modules.editor.mimelookup.MimePathLookup.beforeLookup(MimePathLookup.java:103)
          org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:658)
          org.openide.util.lookup.ProxyLookup$R.computeResult(ProxyLookup.java:520)
          org.openide.util.lookup.ProxyLookup$R.allInstances(ProxyLookup.java:491)
          org.netbeans.modules.parsing.impl.indexing.IndexerCache.collectIndexerFactoriesRegisteredForEachParticularLanguage(IndexerCache.java:330)
          org.netbeans.modules.parsing.impl.indexing.IndexerCache.getData(IndexerCache.java:371)
          org.netbeans.modules.parsing.impl.indexing.IndexerCache.getIndexersMap(IndexerCache.java:130)
          org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$SourceIndexers.&lt;init&gt;(RepositoryUpdater.java:3781)
          org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$SourceIndexers.load(RepositoryUpdater.java:3763)
          org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$InitialRootsWork.getDone(RepositoryUpdater.java:3306)
          org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doTheWork(RepositoryUpdater.java:2042)
          org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task._run(RepositoryUpdater.java:3644)
          org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task.run(RepositoryUpdater.java:3583)
          org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:595)
          java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
          java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
          java.util.concurrent.FutureTask.run(FutureTask.java:138)
          java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
          java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
          java.lang.Thread.run(Thread.java:619)
        </stacktrace>
      </violator>
Comment 1 Jaroslav Tulach 2010-11-08 14:56:08 UTC
Created attachment 102847 [details]
Here are the allocation stack traces for all the current violators

The list of kits violating the blacklist is 

      <violator class="org.netbeans.modules.cnd.asm.core.editor.AsmEditorKit">
      <violator class="org.netbeans.modules.cnd.editor.cplusplus.HKit">
      <violator class="org.netbeans.modules.cnd.editor.fortran.FKit">
      <violator class="org.netbeans.modules.cnd.makefile.editor.MakefileKit">
      <violator class="org.netbeans.modules.cnd.script.editor.ShellKit">
      <violator class="org.netbeans.modules.csl.core.CslEditorKit">
      <violator class="org.netbeans.modules.db.sql.editor.SQLEditorKit">
      <violator class="org.netbeans.modules.editor.plain.PlainKit">
      <violator class="org.netbeans.modules.groovy.gsp.editor.GspKit">
      <violator class="org.netbeans.modules.html.editor.api.HtmlKit">
      <violator class="org.netbeans.modules.profiler.oql.language.OQLEditorKit">
      <violator class="org.netbeans.modules.properties.syntax.PropertiesKit">
      <violator class="org.netbeans.modules.ruby.rhtml.editor.RhtmlKit">
      <violator class="org.netbeans.modules.web.core.syntax.JspKit">
      <violator class="org.netbeans.modules.xml.text.syntax.ENTKit">
Comment 2 Dusan Balek 2010-11-10 09:41:20 UTC
Fixed in jet-main.

http://hg.netbeans.org/jet-main/rev/99157fe42c28
Comment 3 Quality Engineering 2010-11-11 06:10:44 UTC
Integrated into 'main-golden', will be available in build *201011110000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/99157fe42c28
User: Dusan Balek <dbalek@netbeans.org>
Log: Issue #191732: Ruby, Groovy, PHP Kits loaded for JavaSE project by Preformating65 - fixed.
Comment 4 Jaroslav Tulach 2010-11-12 15:14:23 UTC
Kits are gone. Thanks.

Btw. there is now quite a lot of new lucene classes
http://deadlock.netbeans.org/hudson/job/ergonomics/lastSuccessfulBuild/artifact/ide.kit/build/test/qa-functional/work/o.n.t.i.W/testWhitelist3/whitelist_violators_3.txt
that is OK, I guess.