This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 19109 - the jspCompoundBreakpoint is not delete
Summary: the jspCompoundBreakpoint is not delete
Status: CLOSED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Code (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P2 blocker (vote)
Assignee: Jan Jancura
URL:
Keywords:
: 20727 21045 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-01-07 17:50 UTC by Damian Frach
Modified: 2002-03-21 11:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
changed sources (11.37 KB, application/octet-stream)
2002-02-26 15:55 UTC, Damian Frach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Damian Frach 2002-01-07 17:50:01 UTC
- mount a FS
- convert to web module
- set the tomcat 32 as default server
- create a jsp
- compile the jsp
- show a servlet
- add a servlet breakpoint
- a jsp breakpoint automatically generated is pink
- compile a JSP

- by this time the JSP breakpoint is delete (br.remove())

- debugger.getBreakpoints() -> there is still the JSPServletBreakpoint, but 
should be deleted
- debugger window/breakpoints -> there are still JSP and servlet breakpoint; 
there should be nothing
- servlet line is white, but jsp line is still pink, what is bad
Comment 1 Damian Frach 2002-02-26 13:03:15 UTC
*** Issue 20727 has been marked as a duplicate of this issue. ***
Comment 2 Damian Frach 2002-02-26 13:05:11 UTC
because duplicated bug is P2
Comment 3 Damian Frach 2002-02-26 13:05:39 UTC
another reproduction:

When a JSP breakpoint is toggled on, it is added to the list of 
breakpoints in 
the Debugger Window.  However, when the breakpoint is toggled off, it 
is not 
removed from the Debugger Window.  If the breakpoint is then toggled 
back on, a 
duplicate breakpoint is added to the Debugger Window.
Comment 4 Damian Frach 2002-02-26 13:10:38 UTC
fixed was found and is simple

- CoreBreakpoint.getGroup will be public and not protected
  (debugger core module)

- JspCompoundEvent.remove will call myGroup.delete()
  (web module)

Comment 5 Damian Frach 2002-02-26 14:41:18 UTC
another problems; we will try to find better and safe way, how to get 
breakpointGroup during jspCompoundEvent.remove
Comment 6 Damian Frach 2002-02-26 15:52:53 UTC
new fix was found:

org/netbeans/modules/web/debug/JspCompoundEvent.java

>         BreakpointGroup bg = getBreakpoint().getGroup();
>         if (bg != null) ((BreakpointGroupSupport)bg).delete();


org/netbeans/modules/debugger/BreakpointGroup.java

<         breakpoint.setGroup (null);
---
> //        breakpoint.setGroup (null);


org/netbeans/modules/debugger/CoreBreakpoint.java

<     protected BreakpointGroup getGroup () {
---
>     public BreakpointGroup getGroup () {

Comment 7 Damian Frach 2002-02-26 15:55:32 UTC
Created attachment 4826 [details]
changed sources
Comment 8 Jan Jancura 2002-02-27 16:55:10 UTC
fixed in main trunk
Comment 9 Damian Frach 2002-02-28 06:46:14 UTC
3.3.2 candidate
Comment 10 Damian Frach 2002-03-01 12:37:14 UTC
*** Issue 21045 has been marked as a duplicate of this issue. ***
Comment 11 Damian Frach 2002-03-05 13:17:18 UTC
integrated into the orion_fcs branch