This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 189476 - User can't close a renamed project
Summary: User can't close a renamed project
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Project (show other bugs)
Version: 7.0
Hardware: PC Linux
: P2 normal (vote)
Assignee: Thomas Preisler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 09:34 UTC by soldatov
Modified: 2010-10-06 13:22 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description soldatov 2010-08-13 09:34:22 UTC
Scenario:
- Create Welcome project
- Call context menu on project's node. Select Rename... menu item
- Set "Also Rename Project Folder" = true
- Type Welcome_ZZZZZZZ in text field
- Press Rename button
===> Project has old name (Welcome_3) and I can't close this project
Comment 1 soldatov 2010-08-20 08:09:03 UTC
I really think it is a P2. IZ189681 and IZ189476 blocks automatic GUI tests. And I don't think we need to fix tests. Temporary solution: No fix ==> No test result
Comment 2 soldatov 2010-08-25 11:47:35 UTC
Upgraded to P1, because it is tests stopper
Comment 3 Thomas Preisler 2010-08-25 17:29:56 UTC
Problem confirmed. Also confirmed that it is a regression in trunk. 6.9.1 works fine.
Comment 4 Thomas Preisler 2010-08-26 04:58:58 UTC
Pretty sure it is a race condition 'somehere'. Not always reproducible and and for me only on Solaris using VPN.

Looks like *two* projects are created and it is causing various problems.

Looks like one instance is correctly created by NB project system when it is moved, see first stack trace below. Then a second instance is crated from ProjectManager.findProject() called by various clients like file owner query and also CND. See second stack trace below. Why isn't the project system returning the project already created? Is this the bug? Need more investigation.

---------------MakeProject MakeProject[MasterFileObject[/home/thp/NetBeansProjects/Welcome_13ab@6c0ee9:db33bc,valid=true]] MasterFileObject[/home/thp/NetBeansProjects/Welcome_13ab@6c0ee9:db33bc,valid=true]
java.io.IOException
        at org.netbeans.modules.cnd.makeproject.MakeProject.<init>(MakeProject.java:183)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
        at org.netbeans.modules.project.ant.AntBasedGenericType.createProject(AntBasedGenericType.java:129)
        at org.netbeans.modules.project.ant.AntBasedProjectFactorySingleton.loadProject(AntBasedProjectFactorySingleton.java:258)
        at org.netbeans.api.project.ProjectManager.createProject(ProjectManager.java:361)
        at org.netbeans.api.project.ProjectManager.access$300(ProjectManager.java:85)
        at org.netbeans.api.project.ProjectManager$2.run(ProjectManager.java:282)
        at org.netbeans.api.project.ProjectManager$2.run(ProjectManager.java:233)
        at org.openide.util.Mutex.readAccess(Mutex.java:330)
        at org.netbeans.api.project.ProjectManager.findProject(ProjectManager.java:233)
        at org.netbeans.modules.project.uiapi.DefaultProjectOperationsImplementation.doMoveProject(DefaultProjectOperationsImplementation.java:503)
        at org.netbeans.modules.project.uiapi.DefaultProjectOperationsImplementation$4.execute(DefaultProjectOperationsImplementation.java:362)
        at org.netbeans.modules.project.uiapi.DefaultProjectOperationsImplementation$6$1.run(DefaultProjectOperationsImplementation.java:641)
        at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1426)

---------------MakeProject MakeProject[MasterFileObject[/home/thp/NetBeansProjects/Welcome_13ab@6c0ee9:db33bc,valid=true]] MasterFileObject[/home/thp/NetBeansProjects/Welcome_13ab@6c0ee9:db33bc,valid=true]
java.io.IOException
        at org.netbeans.modules.cnd.makeproject.MakeProject.<init>(MakeProject.java:183)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
        at org.netbeans.modules.project.ant.AntBasedGenericType.createProject(AntBasedGenericType.java:129)
        at org.netbeans.modules.project.ant.AntBasedProjectFactorySingleton.loadProject(AntBasedProjectFactorySingleton.java:258)
        at org.netbeans.api.project.ProjectManager.createProject(ProjectManager.java:361)
        at org.netbeans.api.project.ProjectManager.access$300(ProjectManager.java:85)
        at org.netbeans.api.project.ProjectManager$2.run(ProjectManager.java:282)
        at org.netbeans.api.project.ProjectManager$2.run(ProjectManager.java:233)
        at org.openide.util.Mutex.readAccess(Mutex.java:330)
        at org.netbeans.api.project.ProjectManager.findProject(ProjectManager.java:233)
        at org.netbeans.modules.cnd.makeproject.api.configurations.MakeConfigurationDescriptor.getProject(MakeConfigurationDescriptor.java:232)
        at org.netbeans.modules.cnd.makeproject.api.configurations.Folder.getProject(Folder.java:296)
        at org.netbeans.modules.cnd.makeproject.api.configurations.Item.getNativeProject(Item.java:432)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase$DefaultFileItem.<init>(ProjectBase.java:2481)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase$DefaultFileItem.toDefault(ProjectBase.java:2488)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase.getMacroMap(ProjectBase.java:1065)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase.createPreprocHandler(ProjectBase.java:1043)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase.createOrFindFileImpl(ProjectBase.java:1850)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase.preCreateIfNeed(ProjectBase.java:821)
        at org.netbeans.modules.cnd.modelimpl.csm.core.ProjectBase.createIfNeed(ProjectBase.java:832)
Comment 5 soldatov 2010-08-26 09:26:43 UTC
I checked latest NetBeans build and I can't reproduce this bug also. I think Rename fails sometimes (for example we have IZ186878), but It is not a P1. Of cause we have other same problems. Now for example I can't rename project If "Also Rename Project Folder" = false.
Comment 6 Thomas Preisler 2010-08-26 20:52:44 UTC
Fixed the issue with renaming without also changing project dir.
Comment 7 Thomas Preisler 2010-08-26 20:53:42 UTC
Original problem still present. Can reproduce on my Solaris box (but not on my Mac).
Comment 8 Quality Engineering 2010-08-28 03:45:37 UTC
Integrated into 'main-golden', will be available in build *201008280001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/65b430182b54
User: Thomas Preisler <thp@netbeans.org>
Log: #189476 - User can't close a renamed project
Fixed rename without also renaming directory
Comment 9 Alexander Simon 2010-09-03 12:59:08 UTC
Fix NPE introduced http://hg.netbeans.org/cnd-main?cmd=changeset;node=79e75882ec3d

Change set:
http://hg.netbeans.org/cnd-main/rev/7d4e8e4afaab

Cannot reproduce bug.
Comment 10 Quality Engineering 2010-09-04 03:43:32 UTC
Integrated into 'main-golden', will be available in build *201009040000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/7d4e8e4afaab
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing BZ#189476 -  User can't close a renamed project
- fix NPE
Comment 11 Alexander Pepin 2010-09-08 14:12:53 UTC
The bug is still reproducible in build 20100907 on Linux.
Comment 12 Alexander Pepin 2010-10-06 13:22:32 UTC
Is not reproducible any more (build 20101006)