This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 187259 - Don't scan $cluster/lib folder for other than platform clusters
Summary: Don't scan $cluster/lib folder for other than platform clusters
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 6.x
Hardware: Other Linux
: P2 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-07 10:00 UTC by Jaroslav Tulach
Modified: 2010-06-16 10:03 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2010-06-07 10:00:21 UTC 
As far as I can tell the nbexec launcher scans lib/ for *.jar only for platform cluster and userdir. Any other clusters are ignored. As such it does not seem right that ModuleListParser by default scans lib cluster for all clusters.

This is causing me problems when importing external clusters which contain lib folder (quite common name) with some strange OSGi bundles.

I am going to scan the lib folder only in platform cluster.
Comment 1 Jaroslav Tulach 2010-06-07 10:04:25 UTC 
core-main#f002b057a516

Please consider backporting to closest post 6.9 release or some of its fix.
Comment 2 Jesse Glick 2010-06-07 18:24:38 UTC 
This directly contradicts the intent of bug #185239.

Perhaps MLP can be made to look up JAR paths from config/Modules/*.xml rather than assuming all {lib,core,modules}/*.jar are modules. I am not sure what other code might make this assumption.
Comment 3 Jaroslav Tulach 2010-06-07 21:01:26 UTC 
MPL does look for config/Modules/*.xml since 6.9. Unfortunately there is no config/Modules/*.xml for JARs in platform/lib, neither in $cluster/core/, so these dirs have to still be scanned. The first only for platform, the later, for each cluster.

I have no opinion about bug 185239. Only that making trade-offs, just to make JavaFX run is not really beneficial for the future.
Comment 4 Quality Engineering 2010-06-08 06:06:22 UTC 
Integrated into 'main-golden', will be available in build *201006080001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/f002b057a516
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #187259: Skip lib directory in any other than platform cluster
Comment 5 Jesse Glick 2010-06-10 15:24:02 UTC 
On second thought I guess it's not a problem. While lib/*.jar could be added to the classpath from other clusters (*), these JARs would not typically be modules anyway.

(*) This would not be only for the benefit of JavaFX; it is occasionally necessary to put something in the app CP.
Comment 6 Jaroslav Tulach 2010-06-11 06:42:55 UTC 
(In reply to comment #5)
> these JARs would not typically be modules anyway.

True. Good reasoning.
Comment 7 rbalada 2010-06-16 10:03:51 UTC 
Transplanted to release691 as bcf74b96ce0f