This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 186847 - NBM is not created correctly if binaries are not downloaded first
Summary: NBM is not created correctly if binaries are not downloaded first
Status: VERIFIED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 6.x
Hardware: PC All
: P1 normal (vote)
Assignee: rnovak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 20:50 UTC by dlipin
Modified: 2010-07-08 11:11 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dlipin 2010-05-27 20:50:42 UTC
See
http://statistics.netbeans.org/analytics/messageslog?id=395151

Checking the appropriate NBM shows that modules/ext/apduio.jar is not really there:
http://download.netbeans.org/netbeans/updates/6.9/uc/final/stable/modules/javacard/org-netbeans-modules-javacard-apdu-io.nbm
The same for English-only NBM hosted on smetiste.

It looks like something wrong with MakeNBM task (or "ant nbm" overall execution?).

Steps to reproduce (as an example)
1) cd javacard.apdu.io
2) rm -tf external/apduio.jar
3) ant nbm
4) build/org-netbeans-modules-javacard-apdu-io.nbm is about 22K in size and does not contain netbeans/modules/ext/apduio.jar.pack.gz inside
5) again do "ant nbm"
6) build/org-netbeans-modules-javacard-apdu-io.nbm is about 47K in size and netbeans/modules/ext/apduio.jar.pack.gz is there

That is in current dev build but it also reproducible in RC1 build.
Probably the issue is that the list of module files when making NBM is determined before all the binaries are downloaded. 
Also maybe the result of 
http://hg.netbeans.org/main-silver/rev/dff9b00e4ebb
And also maybe due to changes made for performing pack200 compression.
Comment 1 Jesse Glick 2010-05-28 14:54:13 UTC
core-main #371c05806f38
Comment 2 dlipin 2010-05-28 15:00:53 UTC
It should be pushed to release69 as well. Without that we'll have invalid NBMs on Update Center.
Comment 3 Jesse Glick 2010-05-28 15:02:15 UTC
Just an ordering issue; if you have not run download-all-extbins, and the NBM which you are creating was not in a cluster config used to do a regular build, then the file list is determined prior to the extbin download. May or may present itself depending on what exactly the builder is doing. http://download.netbeans.org/netbeans/updates/6.9/uc/final/stable/ would have to be rebuilt if it is affected; I have no idea what process creates this UC. nbms-and-javadoc is not affected AFAIK.
Comment 4 Jesse Glick 2010-05-28 15:04:30 UTC
I see no compelling need to port it to 6.9 when (a) it affects only nb.org modules, (b) there is a trivial workaround: download-all-extbins. Again it depends on what the build processes are. Better for Robert to evaluate.
Comment 5 Jesse Glick 2010-05-28 15:04:54 UTC
(Not sure why Robert is not default assignee for nbbuild issues...?)
Comment 6 Quality Engineering 2010-05-30 07:11:28 UTC
Integrated into 'main-golden', will be available in build *201005300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/371c05806f38
User: Jesse Glick <jglick@netbeans.org>
Log: #186847: NBM is not created correctly if binaries are not downloaded first
Comment 7 Antonin Nebuzelsky 2010-05-31 10:02:48 UTC
Robert, please comment about an importance of this fix for 6.9.
Comment 8 rnovak 2010-06-01 10:52:24 UTC
I strongly recommend to integrate this fix to release69 branch, but it is not a show stopper for the release. I'm aware of 3 modules that are affected by this issue and these modules are only available on the UC. There is simple workaround how to build the correct NBMs, but it would be good to fix it at least for sustaining.
Comment 9 Antonin Nebuzelsky 2010-06-01 14:23:34 UTC
Robert, please, take care of the fix for release69. Jesse is on vacation this week. Thanks!
Comment 10 dlipin 2010-06-04 13:33:48 UTC
We already have it in 6.9:
http://hg.netbeans.org/release69/rev/625b842a3e76
Comment 11 Jesse Glick 2010-06-08 21:26:32 UTC
BTW whoever did the transplant, I recommend you set

[defaults]
transplant = --log

in ~/.hgrc, to clearly differentiate original changesets from transplants.
Comment 12 rbalada 2010-06-14 07:54:30 UTC
Is it safe to transplant this fix to release691 repository? Please mark it as verified (if it was verified).
Comment 13 rbalada 2010-06-14 08:31:05 UTC
Oops, correction. This fix has already been applied in release691 repository as b50be9c66434

Please mark it verified asap.
Comment 14 rbalada 2010-06-14 08:38:23 UTC
Added keyword 6.9.1_CANDIDATE to bugfixes, which were integrated in release69 repository *after* the release691 clone has been created.
Comment 15 rbalada 2010-06-16 09:07:40 UTC
Marking Verified
Comment 16 Martin Fousek 2010-07-08 11:11:44 UTC
Checked and verified for NetBeans IDE 6.9.1 - Build 100708-a58e197550e6.