This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 186293 - Functions and classes from oci8.php signature file are not displayed in CC
Summary: Functions and classes from oci8.php signature file are not displayed in CC
Status: VERIFIED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Editor (show other bugs)
Version: 6.x
Hardware: PC Linux
: P1 normal (vote)
Assignee: rmatous
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 11:38 UTC by Petr Pisl
Modified: 2010-06-09 20:25 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2010-05-18 11:38:03 UTC 
We have signature file for OCI classes and functions, but the code completion doesn't offer them. It can be bigger problem, then just for OCI. Please evaluate.
Comment 1 rmatous 2010-05-18 14:38:21 UTC 
signature file for OCI classes contains errors. This file is generated by script from documentation taken from php.net, which contains bugs. 

Fix will contain:
- changes in signature files made by hand
- PHPIndexer(extending EmbeddingIndexer) will contain cod like this:

assert r.getDiagnostics().isEmpty() || !PhpSourcePath.FileType.INTERNAL.equals(PhpSourcePath.getFileType(fileObject)) : fileObject.getPath();

which should ensure that next time the problems will be revealed early
Comment 2 Petr Pisl 2010-05-18 15:06:56 UTC 
There is one more signature file ncurses.php that has also syntax error.
Comment 3 rmatous 2010-05-18 15:32:42 UTC 
http://hg.netbeans.org/web-main/rev/76dd9497b758

Fixed as mentioned in the previous comment, fixes naturally ncurses and oci and assertion error will be thrown when problems in signature files
Comment 4 rmatous 2010-05-19 13:01:03 UTC 
filipe if you(QA) agree then please add keyword 69_HR_FIX_CANDIDATE to this issue. I would like to see it fixed for 6.9
Comment 5 Filip Zamboj 2010-05-19 16:50:38 UTC 
verified 
Product Version: NetBeans IDE Dev (Build 100519-1cdfb4367984)

feel free to add changes to 69clone.
Comment 7 Quality Engineering 2010-05-20 06:15:22 UTC 
Integrated into 'main-golden', will be available in build *201005192201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/76dd9497b758
User: Radek Matous <rmatous@netbeans.org>
Log: #186293 - Functions and classes from oci8.php signature file are not displayed in CC
Comment 8 Filip Zamboj 2010-06-09 20:25:41 UTC 
Product Version: NetBeans IDE 6.9 (Build 100609-a94d6a4a87fe)
Java: 1.6.0_16; Java HotSpot(TM) 64-Bit Server VM 14.2-b01

verified in release69 clone