This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 183792 - LowPerformance took 4071 ms.
Summary: LowPerformance took 4071 ms.
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Tomasz Slota
URL:
Keywords: PERFORMANCE
: 183169 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-04-09 16:38 UTC by malfunction84
Modified: 2010-05-10 09:18 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 156900

Attachments
nps snapshot (256.00 KB, application/nps)
2010-04-09 16:38 UTC, malfunction84 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description malfunction84 2010-04-09 16:38:30 UTC 
Build: NetBeans IDE Dev (Build 201002152000)
VM: Java HotSpot(TM) 64-Bit Server VM, 16.0-b13, Java(TM) SE Runtime Environment, 1.6.0_18-b07
OS: Windows Vista

User Comments:
facilityderek: Opened a JSP containing sriptlets, javascript, and tag libraries.

This file opened long after project scanning had stopped. Other files had been opend previously without delay.

GUEST: This happens often when i work on jsp/jsf/jspx files

malfunction84: Opening a file

GUEST: Editing GWT JSP page.



Maximum slowness yet reported was 26390 ms, average is 7265
Comment 1 malfunction84 2010-04-09 16:38:37 UTC 
Created attachment 96975 [details]
nps snapshot
Comment 2 Marek Fukala 2010-05-06 11:13:41 UTC 
((JspDataObject) getDataObject()).updateFileEncoding(false) cannot be called from EditorSupport.open() since it runs in AWT thread. This was done because we tested if the encoding is valid and if not showed a dialog asking the user whether he wants to open the file or not.

Since we cannot determine the encoding in the AWT thread and then possibly cancel the execution, I've changed the behaviour so the file is opened everytime, but if the encoding is detected as errorneous a warning dialog pops up and warns the user about that. This happens in EditorSupport.loadFromStreamToKit() where its safe to call the parser since the method runs asynchronously.

fixed in web-main#242e00358e7c
Comment 3 Marek Fukala 2010-05-06 11:37:17 UTC 
*** Bug 183169 has been marked as a duplicate of this bug. ***
Comment 4 Quality Engineering 2010-05-10 09:18:42 UTC 
Integrated into 'main-golden', will be available in build *201005100200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/
User: 
Log: