To further limit list of loaded classes coming from serverplugins. We should not load OptionalDeploymentManagerFactory.
In fact this means no instantiation it when finishServerInitialization is noop.
Please review the api change. The patch is supposed to be applied to sources with applied changes from #148177.
Created attachment 94282 [details]
Are we doing this just to avoid loading 5 classes on startup, when at the same time we load 4 new classes?
*.glassfish.* classes were missing in the whitelist. Actually not related to the change, sorry for the confusion. Correct "rate" is 5/1.
Y01 A bit safer way to initialize in constructor is:
this.noInitializationFinish = Boolean.TRUE.equals(
Y02 I like the change. It is compatible, safe and improves scalability of the infrastructure. Together with the other changes we are on good track to eliminate loading in any code of non-installed server plugins completely.
Re Y01: Absolutely. I'll fix it before commit.
I'll integrate the change tomorrow.
Fixed in web-main 98591e9cd524.
Integrated into 'main-golden', will be available in build *201002260200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
User: Petr Hejl <email@example.com>
Log: #180893: Do not load OptionalDeploymentManagerFactory when not really needed