This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 180578 - "nbms" target in suite.xml is inefficient - "netbeans" target is called twice for each module in suite
Summary: "nbms" target in suite.xml is inefficient - "netbeans" target is called twice...
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Jesse Glick
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2010-02-10 15:18 UTC by dlipin
Modified: 2010-03-17 05:17 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dlipin 2010-02-10 15:18:09 UTC 
Current implementation of "nbms" target in suite.xml looks inefficient. In particular, it builds each module twice - once by calling its "netbeans" target (using subant in "build" target), and then "nbm" (using subant in "nbms") which, in turn, calls "netbeans" as the dependent target.

suite.xml:
<target name="build" depends="-init,branding,release" description="...">
    <subant target="netbeans" buildpath="${modules.sorted}" inheritrefs="false" inheritall="false"/>
         ....
</target>
<target name="nbms" depends="build" description="...">        
    .... 
<subant target="nbm" buildpath="${modules.sorted}" inheritrefs="false" inheritall="false">
            <property name="nbm.target.dir" location="${build.updates.dir}"/>
            <property name="${nbm.target.cluster.name}" value="${help.target.cluster}" />
        </subant>
    ....
</target>

common.xml:
<target name="nbm" depends="init,netbeans,-nbm-prompt-for-storepass" description="...">...</target>
<target name="netbeans" depends="...,release,...">....</target>

PS. Adam uses the following workaround in the customized harness, not sure whether it is generally suitable to inclusion into main harness:
http://hg.netbeans.org/javafx/rev/eca5f1be6c30
Comment 1 Jesse Glick 2010-02-10 15:40:43 UTC 
(In reply to comment #0)
> not sure
> whether it is generally suitable to inclusion into main harness:
> http://hg.netbeans.org/javafx/rev/eca5f1be6c30

First diff hunk probably yes. Second hunk looks unrelated.
Comment 2 Adam Sotona 2010-02-11 01:11:32 UTC 
Second hunk is a copy/paste of the missing code when the dependency gets removed in the first hunk. I expected this code is important so to be called before modules build.
Comment 3 Jesse Glick 2010-03-16 00:35:21 UTC 
core-main #1ec395bb243b
Comment 4 Quality Engineering 2010-03-17 05:17:44 UTC 
Integrated into 'main-golden', will be available in build *201003170201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/1ec395bb243b
User: Jesse Glick <jglick@netbeans.org>
Log: #180578: make only one pass over a suite when building nbms.