This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 177088 - [68cat] most XHTML code flagged as error
Summary: [68cat] most XHTML code flagged as error
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSF Editor (show other bugs)
Version: 6.x
Hardware: PC Linux
: P1 normal (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-18 07:17 UTC by gholmer
Modified: 2009-11-25 03:18 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screen shot (65.74 KB, image/png)
2009-11-18 07:17 UTC, gholmer
Details
Zipped sample Richfaces project with custom taglib (19.73 KB, application/x-zip-compressed)
2009-11-18 09:47 UTC, jpleed3
Details
Another test with a custom taglib in an included jar (47.71 KB, application/x-zip-compressed)
2009-11-24 07:20 UTC, jpleed3
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gholmer 2009-11-18 07:17:04 UTC
Created attachment 91254 [details]
screen shot

Starting with 200911170201 (I'm also seeing it in 200911171401), nearly all the code in my Facelets XHTML files is flagged as errors.  See attached screen shot.
Comment 1 jpleed3 2009-11-18 08:01:24 UTC
I'm seeing it for all RichFaces / ajax4jsf tags and my custom taglibs. In a few of my xhtml's, 75% of the error bar is red. The error lines include anywhere a rich/a4j tag is used as well as the namespace declarations.

I'm seeing the issue in build 200911160201.
Comment 2 Marek Fukala 2009-11-18 08:58:59 UTC
Duplicate of issue 176992 and 176891, both already fixed.

I am sorry for the problems.

Please verify ASAP once you have a build with both fixes. Then reopen if still happens.

BTW I would really appreciate if you attached a project which I can use to verify that the issue is really fixed. Since it may take some time until the build is done.

*** This bug has been marked as a duplicate of bug 176992 ***
Comment 3 Marek Fukala 2009-11-18 09:08:08 UTC
Hmm, not fixed yet. Reproducible for third party libraries like icefaces, richfaces etc.

This must be fixed in 6.8
Comment 4 jpleed3 2009-11-18 09:47:59 UTC
Created attachment 91272 [details]
Zipped sample Richfaces project with custom taglib

This should show you the errors for custom taglibs and for Richfaces. To cut down the size, I didn't include any libraries. Add Richfaces api, impl, and ui as "RichFaces-3.3.x". The JSF / Facelets lib is straight from Plugins manager.

Also, this project uses the facelets.LIBARIES context-param to let Facelets know about the custom taglib, but I usually stick the *.taglib.xml in the META-INF folder of an included jar.
Comment 5 gholmer 2009-11-18 10:29:01 UTC
My project is ~36M, but I can send it if necessary.  It's too big for an attachment, isn't it?
Comment 6 Marek Fukala 2009-11-19 07:44:58 UTC
fixed in web-main#5e38a11ba9b9

The attached sample "Facelets Error Test" project is no without any false error.

I've also found another bug - you are using the old facelets library specification parameter name

    <context-param>
        <param-name>facelets.LIBRARIES</param-name>
        <param-value>/WEB-INF/core.taglib.xml</param-value>
    </context-param>

According to JSF2.0 there is supposed to be javax.faces.FACELETS_LIBRARIES as a param name.

I fixed this as well so the custom library is properly parsed and the support works fine for it.

Thanks for the report. Please verify once you manage to get a build with the fix.
Comment 7 jpleed3 2009-11-19 08:30:33 UTC
I'm not sure if you meant that it was your bug or mine insofar as the context-param. Unfortunately, there isn't a JSF 2.0 compatible version of RichFaces yet, so I've been using 6.8 with JSF 1.2 and Facelets 1.14. Hopefully in the next week I'll be able to switch over using one of the dev builds of RF 3.3.3.

Also, did you check against having the x.taglib.xml in an included jar in META-INF without the web.xml entry?
Comment 8 Quality Engineering 2009-11-20 03:14:08 UTC
Integrated into 'main-golden', will be available in build *200911200201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/5e38a11ba9b9
User: Marek Fukala <mfukala@netbeans.org>
Log: #177088 -  [68cat] most XHTML code flagged as error
Comment 9 Jindrich Sedek 2009-11-24 06:21:41 UTC
it works well in latest build. I see just one error on line with:
<rich:calendar value="#{test.date}" allowManualInput="true" />
because of undefined attribute 'allowManualInput', but in my version of richfaces this attributes is really undefined.
Comment 10 jpleed3 2009-11-24 07:18:56 UTC
Oops! The rich:calendar attribute I meant to use was enableManualInput, but I suppose it didn't hurt to put an attribute in that actually was incorrect.

Build 200911220201 is picking up custom taglibs in the way I defined in the test, but still isn't picking them up when they are in an included jar. I'll submit a new test package for you.
Comment 11 jpleed3 2009-11-24 07:20:22 UTC
Created attachment 91604 [details]
Another test with a custom taglib in an included jar
Comment 12 Marek Fukala 2009-11-24 09:43:50 UTC
The case with composite library worked, I'll check the project, thanks.
Comment 13 Marek Fukala 2009-11-24 11:02:20 UTC
It works fine, but you need to add a dependency directly to the library artifact (jar file), not the library itself. 

I am closing the issue as fixed, new issue for this particular problem has been filed as Bug 177540 -  JSF support doesn't index project dependencies properly
Comment 14 Martin Schovanek 2009-11-25 03:18:48 UTC
Verified at the release68 by QE.