This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 175449 - Method FileUtil.getArchiveFile(URL) should throw some exception.
Summary: Method FileUtil.getArchiveFile(URL) should throw some exception.
Status: RESOLVED INVALID
Alias: None
Product: platform
Classification: Unclassified
Component: Filesystems (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 16:21 UTC by Jan Jancura
Modified: 2010-04-14 14:16 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Jancura 2009-10-26 16:21:45 UTC 
Method FileUtil.getArchiveFile(URL) implementation creates URL for embedded file. It catches MalformedURLE and writes
message to console. I think that MUE should not be catched here.
Comment 1 Jiri Skrivanek 2009-10-29 11:50:13 UTC 
OK, probably only valid jar URL is expected but javadoc doesn't say this.
Comment 2 Jaroslav Tulach 2010-04-07 20:29:05 UTC 
I can't enhance existing signature with throws.
Comment 3 Jan Jancura 2010-04-07 20:48:29 UTC 
You should find some other solution. You can create a new method and deprecate current one, for example. Or update JavaDoc at least.
Comment 4 Jaroslav Tulach 2010-04-07 21:59:08 UTC 
Feel free to provide a patch and pass API review.
Comment 5 Jan Jancura 2010-04-08 07:53:12 UTC 
nice try ;)
Comment 6 Jaroslav Tulach 2010-04-09 18:52:07 UTC 
I am not going to implement this. Either you can provide a patch, or leave it closed.
Comment 7 Jan Jancura 2010-04-12 08:07:23 UTC 
This issue is still valid.
Comment 8 Jaroslav Tulach 2010-04-12 09:03:04 UTC 
Moving away into common pool of issues that are not going to be addressed.
Comment 9 Jan Jancura 2010-04-13 14:09:52 UTC 
?!?!?!
All issues should be addressed, I think.
Or can you point me to some new rules?
Comment 10 Jaroslav Tulach 2010-04-13 17:55:45 UTC 
> Method FileUtil.getArchiveFile(URL) implementation creates URL for embedded
> file. It catches MalformedURLE and writes
> message to console. I think that MUE should not be catched here.

Hanzi, what is your inquiry? You "think" that there is a problem? Fine, but that does not qualify for a bug. If someone adds new method, will it fix something? No. Nobody will call that method. So try to be less Jančura centric and return back to some engineering senses. This is not a bug, this is at most enhancement and also one without completely unclear benefits. Regards.
Comment 11 Marian Mirilovic 2010-04-14 09:39:52 UTC 
> Moving away into common pool of issues that are not going to be addressed.

Honestly IDE/Code is not that place. Close an issue as WONTFIX if you do not want to address it, but do not move into IDE/Code - this is place for newly reported issues and it's under close review of QA to reassign such issues into appropriate modules.
Comment 12 Jan Jancura 2010-04-14 14:16:10 UTC 
Sorry Jardo. I was completely wrong.
I will never do it again.