This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 174460 - Cannot set breakpoint at .jsp
Summary: Cannot set breakpoint at .jsp
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: mslama
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2009-10-13 15:51 UTC by Martin Schovanek
Modified: 2009-10-21 10:29 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schovanek 2009-10-13 15:51:44 UTC 
[#200910130201, jdk1.6]

to reproduce:
-------------
1) open a .jsp
2) try to set a breakpoint
ERROR: IDE does nothing.
Comment 1 Petr Jiricka 2009-10-14 16:14:56 UTC 
I can reproduce. Martin E, could you please investigate? I don't think we did any changes in the JSP debugger that could
affect this. Thanks.
Comment 2 Martin Entlicher 2009-10-14 17:25:40 UTC 
Reproduced as well.
This is most probably caused by the fix of issue #168415.

NbDocument.findRecentEditorPane(org.netbeans.modules.web.core.jsploader.BaseJspEditorSupport) returns null.

This may be similar problem to issue #172889.
Comment 3 Martin Entlicher 2009-10-14 17:26:43 UTC 
Reassigning for evaluation.
Comment 4 mslama 2009-10-14 17:46:36 UTC 
I will look at it.
Comment 5 mslama 2009-10-15 11:48:37 UTC 
Reason why it does not work is that BaseJspEditorSupport$BaseJspEditor.componentActivated does not call
super.componentActivated. I will fix this and I also check possibility to add warning to
CloneableEditorSupport.getRecentPane when lastSelectedPane is not set. I will also update javadoc of
CloneableEditor.componentActivated.
Comment 6 mslama 2009-10-15 12:41:29 UTC 
core-main #718922b0a1d1
Comment 7 Petr Jiricka 2009-10-15 12:58:50 UTC 
Thanks a lot! Looks like this regression was caused by Marek F's fix of issue 171046:
http://hg.netbeans.org/main-golden/rev/ef2e8682300e. Cc'ing Marek F so he can review.
Comment 8 Quality Engineering 2009-10-16 10:14:28 UTC 
Integrated into 'main-golden', will be available in build *200910160201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/718922b0a1d1
User: Marek Slama <mslama@netbeans.org>
Log: #174460: Call super.componentActivated in CloneableEditor subclass to call setLastSelected on editor support.
Comment 9 Martin Schovanek 2009-10-21 10:29:33 UTC 
v.