This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 167837 - Cannot accept non-LF line endings in 'svn:ignore' property
Summary: Cannot accept non-LF line endings in 'svn:ignore' property
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Marian Petras
URL:
Keywords:
: 170235 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-29 21:40 UTC by _ gtzabari
Modified: 2009-08-13 17:58 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
messages.log (61.10 KB, text/plain)
2009-06-29 21:40 UTC, _ gtzabari
Details
testcase (806.13 KB, application/x-compressed)
2009-07-01 06:22 UTC, _ gtzabari
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ gtzabari 2009-06-29 21:40:27 UTC
When I try to commit a new project using Netbeans I get:

org.tigris.subversion.javahl.ClientException: Wrong or unexpected property value
Commit failed (details follow):
While preparing 'C:\Users\Gili\Documents\blueeye\trunk\concurrent\libraries\junit_4\junit-4.5-api.zip' for commit
Cannot accept non-LF line endings in 'svn:ignore' property

The messages.log contains quite a bit useful information so I'll attach it for you.
Comment 1 _ gtzabari 2009-06-29 21:40:49 UTC
Created attachment 84152 [details]
messages.log
Comment 2 _ gtzabari 2009-06-29 21:42:05 UTC
The server is version 1.6.2 (r37639).
Comment 3 Marian Petras 2009-06-30 18:45:51 UTC
Gili, did you load Subversion properties from a file before you encountered the bug? Or did you copy some multi-line
property value from the clipboard?

(To load Subversion properties from a file, open the "Svn Properties Editor" and press button "Load".)
Comment 4 Marian Petras 2009-06-30 19:13:25 UTC
Which version do you have? Could you post here the first two lines of output of command "svn --version"?
Comment 5 _ gtzabari 2009-06-30 23:08:36 UTC
No, I did not touch SVN properties at all. It is worth noting that I only have this problem with a specific project
while all others work just fine. I could zip up that project for your review if you wish as it's relatively small and
doesn't contain any IP.

I reproduced this issue under both "version 1.6.2 (r37639)" and "svn, version 1.6.3 (r38063) compiled Jun 18 2009,
12:57:17" which is the latest Windows version at the time of this post.
Comment 6 Ondrej Vrabec 2009-07-01 06:11:47 UTC
> I could zip up that project for your review if you wish as it's relatively small and
doesn't contain any IP.
That would be great. We could check the files and svn metadata, thanks.
Comment 7 _ gtzabari 2009-07-01 06:22:53 UTC
Created attachment 84219 [details]
testcase
Comment 8 Marian Petras 2009-07-14 14:27:25 UTC
Gili, wasn't the Subversion server upgraded to a newer version recently?

According to this message:

    http://subversion.open.collab.net/ds/viewMessage.do?dsForumId=3&dsMessageId=315838

Subversion only started to really check for non-LF endings in the 1.6.x series.

There is a Subversion bug filed that is very similar to this NetBeans one:

    http://subversion.tigris.org/issues/show_bug.cgi?id=3404

    Citation:
    "Subversion 1.6 no longer accepts carriage returns (^M) in the values of its own properties (i.e. svn:log,
    svn:ignore and others). Prior to 1.6 such properties were accepted.

    svnsync 1.6 fails when the source repository violates eol-purity on any of the relevant properties.

    A great many such repositories exist in the wild because Subclipse was -- until very recently -- sloppy 
    with line endings when running on Windows."
Comment 9 _ gtzabari 2009-07-19 06:13:21 UTC
I've listed the version numbers I've seen this problem with (1.6.2 and 1.6.3) above. Yes, this is most probably caused
by the fact that newer Subversion servers are stricter, but it isn't clear what is the appropriate thing to do in this case.

From an end-user point of view, I did nothing wrong (properties were set automatically for me by Netbeans or
TortoiseSVN) and yet I am getting an error message. At the very least, Netbeans should tell me how to correct the
problem. Ideally, it should correct the problem automatically.
Comment 10 Ondrej Vrabec 2009-08-12 13:50:17 UTC
I think i found the problem. In your project there's a folder '.../libraries' which contains subversion metadata (a .svn
folder) and inside a property file 'dir-props'. This property file contains the 'CRLF' line-ending that causes trouble.

So to make the project working again, run:
1) svn propset svn:ignore '' libraries
2) svn propset svn:ignore 'nblibraries-private.properties' libraries

I will meantime try to fix the cause, why the file contains the 'CRLF' line-ending.
Comment 11 Ondrej Vrabec 2009-08-12 13:51:42 UTC
*** Issue 170235 has been marked as a duplicate of this issue. ***
Comment 12 Ondrej Vrabec 2009-08-12 14:27:43 UTC
fixing in cdev #229911e064ee
i hope it would help and prevent from svn:ignore values with crlf line-endings
Comment 13 Quality Engineering 2009-08-13 17:58:09 UTC
Integrated into 'main-golden', will be available in build *200908131401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/229911e064ee
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #167837 - Cannot accept non-LF line endings in 'svn:ignore' property
we build the svn:ignore value ourselves and don't use setIgnoredPatterns anymore